Debian Bug report logs - #1021792
vart: reproducible builds: Embeds build time in in various binaries

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: vart: reproducible builds: Embeds build time in in various binaries

Date: Fri, 14 Oct 2022 12:44:18 -0700

[Message part 1 (text/plain, inline)]

Source: vart
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build time is embedded in various binaries:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/vart.html

  /usr/lib/x86_64-linux-gnu/libvart-buffer-object.so.2.5.0

  Xilinx·vart-buffer-object·Version:·2.5.0-··2023-11-14-01:55:35·
  vs.
  Xilinx·vart-buffer-object·Version:·2.5.0-··2022-10-12-21:36:55·

The attached patch to the two upstream cmake files fixes this by using
the TIMESTAMP function of cmake rather than calling date directly.

According to my local tests, with this patch applied, vart should build
reproducibly on tests.reproducible-builds.org once it migrates to
bookworm/testing! Differing build paths trigger additional issues, which
are only tested in unstable and experimental.

Thanks for maintaining vart!

live well,
  vagrant

[0001-Use-cmake-TIMESTAMP-feature-instead-of-calling-date-.patch (text/x-diff, inline)]

From 1c216f4f812bbbaa6af1b624191fa2c6813c72df Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 14 Oct 2022 19:31:36 +0000
Subject: [PATCH 1/2] Use cmake TIMESTAMP feature instead of calling "date"
 directly.

The cmake TIMESTAMP function respects SOURCE_DATE_EPOCH, allowing
reproducible timestamps when specified.
---
 cmake/VitisVersion.cmake      | 6 ++----
 trace/vaitrace/CMakeLists.txt | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/cmake/VitisVersion.cmake b/cmake/VitisVersion.cmake
index 9801037..4969018 100644
--- a/cmake/VitisVersion.cmake
+++ b/cmake/VitisVersion.cmake
@@ -14,10 +14,8 @@
 # limitations under the License.
 #
 #
-execute_process(
-  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-  COMMAND date +%F-%T
-  OUTPUT_VARIABLE BUILD_DATE)
+
+string(TIMESTAMP BUILD_DATE "+%F-%T" UTC)
 string(STRIP "${BUILD_DATE}" BUILD_DATE)
 if ("${GIT_VERSION}" STREQUAL "")
   execute_process(
diff --git a/trace/vaitrace/CMakeLists.txt b/trace/vaitrace/CMakeLists.txt
index 57b7482..de930d7 100644
--- a/trace/vaitrace/CMakeLists.txt
+++ b/trace/vaitrace/CMakeLists.txt
@@ -19,7 +19,7 @@ project(vaitrace VERSION 2.5.20221)
 set(VAITRACE_DEST_PATH bin/xlnx/${PROJECT_NAME})
 
 # Generate Version Flags
-execute_process(COMMAND date +%F-%T OUTPUT_VARIABLE VAITRACE_BUILD_DATE)
+string(TIMESTAMP VAITRACE_BUILD_DATE "+%F-%T" UTC)
 string(STRIP "${VAITRACE_BUILD_DATE}" VAITRACE_BUILD_DATE)
 execute_process(
   WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1021792-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1021792-close@bugs.debian.org

Subject: Bug#1021792: fixed in vart 2.5-2

Date: Wed, 19 Oct 2022 06:27:58 +0000

Source: vart
Source-Version: 2.5-2
Done: Nobuhiro Iwamatsu <iwamatsu@debian.org>

We believe that the bug you reported is fixed in the latest version of
vart, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1021792@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <iwamatsu@debian.org> (supplier of updated vart package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 19 Oct 2022 14:01:22 +0900
Source: vart
Architecture: source
Version: 2.5-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Xilinx Package Maintainers <team+pkg-xilinx@tracker.debian.org>
Changed-By: Nobuhiro Iwamatsu <iwamatsu@debian.org>
Closes: 1021792 1021793
Changes:
 vart (2.5-2) unstable; urgency=medium
 .
   * Drop embeds build time in various binaries. (Closes: #1021792)
     Add 0005-Use-cmake-TIMESTAMP-feature-instead-of-calling-date-.patch.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>.
   * d/rules: Add -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to configure option.
     (Closes: #1021793)
     Fix buildid differences triggered by build paths.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>.
Checksums-Sha1:
 d6ec2457dd96867ac52411ff419d4321a633d3a1 2229 vart_2.5-2.dsc
 eee34ddaa9def6f3a713f7cddeb31a45481bf91f 7020 vart_2.5-2.debian.tar.xz
 599ff77125246a143780c45cfcc1e4df5b491ce1 8777 vart_2.5-2_amd64.buildinfo
Checksums-Sha256:
 8f4242e16279a19b541c4da116423c564a56d1d04ee6899a2e111aa120b71fe2 2229 vart_2.5-2.dsc
 8d32bfa6b6fddcb5f959a990f5f8f8490dbd524ef925b7d6c3d5894498698083 7020 vart_2.5-2.debian.tar.xz
 9a945b35fd1926c62ba32fc72ae2dfe6d5121041d9bbff37b34c73baeec5a1bf 8777 vart_2.5-2_amd64.buildinfo
Files:
 77689d558e91c729327e4024d66cdb21 2229 libs optional vart_2.5-2.dsc
 84958acbd19eb8465fc3e5cbc5503fcb 7020 libs optional vart_2.5-2.debian.tar.xz
 9eac2253d7818eb22669b43d23e998b7 8777 libs optional vart_2.5-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAmNPk50ACgkQMiR/u0Ct
H6Z1NA//WIWqyb4Nr7S6pxeL/TZMAgJ0avu1V3Yt3qAR6HCQcyWniM9voTLMtMwW
SPO8Q9SS4mNH1OgtuzT+yuUtfkzOMA+qJNpXg5dymp6NkyD41DXX+Gvg6biD34/4
iYNDFHq2jSjA5l+cGyJBz3TECtIhFFyANURrZ/08umA1xtjrA/qjZR/OJApjshMQ
DMGhfEgTb0YRBA1Q59a7h2JBgi1i1YorH0nk9ERJsS40BF58r6h2rqtUYzdKi7HV
L8dX66MkOBKeOFzfPg3X0BqPMxmmpAr5MCMYBOHnkiNf3oFmtDfWZ99zFgAxnTSv
4K/IQ25OHfk0LKXbNgw5BT9j/VuL2aYVMMtmzJ4j0tgRmlvQx/yAKW0w/qst3eMA
7dWYdDeT8pgrmtLkcetWUQSQ/SK65+bdGtT9Cwve+BtFl1lmP8Z6zGPGeGWmStk/
WwxEVIdgXRyk4xbFOPEJe/4zAQSqjlm3+AcQcNYnTx+zHBQnFPoTzXJDR5PJfrSt
W6WWTvs9ZZuZrlM9smOYC19fEFgem9KgzewfnqoDvKVVSMAb7NkzfaihcrC8Rbrp
1bX+kMaRhRsAGKlXdVkXcy3xpsE2xCk2ZmacwT6FUnF1QkvsMy5sD6ZMvW0Ox59c
tdMXGc5+fPXO6ngFmvhvTwPbOKeKk/VnlzjJHzpnuE8XY3csyB8=
=voC2
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.