Debian Bug report logs - #1021521
crack: reproducible-builds: build path embedded in various binaries

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: crack: reproducible-builds: build path embedded in various binaries

Date: Sun, 09 Oct 2022 17:42:57 -0700

[Message part 1 (text/plain, inline)]

Source: crack
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in various binaries in /usr/lib/Crack:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/crack.html

  /usr/lib/Crack/cracker

  /build/1st/crack-5.0a/src/util/cracker.c:980
  vs.
  /build/2/crack-5.0a/2nd/src/util/cracker.c:980

The attached patch to debian/Crack.make fixes this by adding the default
CFLAGS to C5FLAGS using dpkg-buildflags.

According to my local tests, with this patch applied, and the patch
recently submitted to fix timestamp issues, crack should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining crack!

live well,
  vagrant

[0001-debian-Crack.make-Use-dpkg-buildflags-to-set-default.patch (text/x-diff, inline)]

From 9238dca4c095b5a914ae5a0c03ffd31d842f1156 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 10 Oct 2022 00:08:01 +0000
Subject: [PATCH 1/4] debian/Crack.make: Use dpkg-buildflags to set default
 CFLAGS.

---
 debian/Crack.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/Crack.make b/debian/Crack.make
index 0d12115..57848b6 100755
--- a/debian/Crack.make
+++ b/debian/Crack.make
@@ -42,7 +42,7 @@ CRACK_PATH=/usr/local/bin:/usr/ccs/bin:/usr/sbin:/sbin:/usr/bin:/bin:/usr/ucb:/u
 # - redhat linux 4.0
 # - digital unix v4.0
 
-C5FLAGS="-DUSE_STRING_H -DUSE_STDLIB_H -DUSE_SIGNAL_H -DUSE_SYS_TYPES_H -DUSE_UNISTD_H -DUSE_PWD_H"
+C5FLAGS="-DUSE_STRING_H -DUSE_STDLIB_H -DUSE_SIGNAL_H -DUSE_SYS_TYPES_H -DUSE_UNISTD_H -DUSE_PWD_H $(dpkg-buildflags --get CFLAGS)"
 
 #
 # now pick your compiler
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.