Debian Bug report logs - #1021520
guymager: reproducible-builds: date in guymager manpage

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: guymager: reproducible-builds: date in guymager manpage

Date: Sun, 09 Oct 2022 17:41:19 -0700

[Message part 1 (text/plain, inline)]

Source: guymager
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The date is embedded in /usr/share/man/man1/guymager.1.gz:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/guymager.html

  TH·guymager·1·"2023-11-10"·"version·0.8.13-1
  vs.
  TH·guymager·1·"2022-10-09"·"version·0.8.13-1

The attached patch to the upstream manuals/rebuild.sh file fixes this by
using SOURCE_DATE_EPOCH to determine the date to embed in the manpage.

According to my local tests, with this patch applied guymager should
build reproducibly on tests.reproducible-builds.org once it migrates to
bookworm/testing! There are other outstanding issues with build-paths,
which are only tested on unstable/experimental.

Thanks for maintaining guymager!

live well,
  vagrant

[0002-manuals-rebuild.sh-Use-SOURCE_DATE_EPOCH-to-set-the-.patch (text/x-diff, inline)]

From af2c2f8de89f0aba6c1579d94f4a70c957aba5ff Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 9 Oct 2022 23:28:44 +0000
Subject: [PATCH 2/2] manuals/rebuild.sh: Use SOURCE_DATE_EPOCH to set the date
 used for manpages.

https://reproducible-builds.org/docs/source-date-epoch/
---
 manuals/rebuild.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/manuals/rebuild.sh b/manuals/rebuild.sh
index bdb4311..b8cf453 100755
--- a/manuals/rebuild.sh
+++ b/manuals/rebuild.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-TH_Date=`date '+%Y-%m-%d'`
+TH_Date=`date --utc --date=@${SOURCE_DATE_EPOCH} '+%Y-%m-%d'`
 TH_Source=`head -qn 1 ../debian/changelog ../changelog 2>/dev/null | awk '{
                                                   Version = $2
                                                   gsub ("\\\\(", "", Version)
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 1021520-submitter@bugs.debian.org (full text, mbox, reply):

From: Michael Prokop <noreply@salsa.debian.org>

To: 1021520-submitter@bugs.debian.org

Subject: Bug#1021520 marked as pending in guymager

Date: Tue, 11 Oct 2022 05:27:39 +0000

Control: tag -1 pending

Hello,

Bug #1021520 in guymager reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/pkg-security-team/guymager/-/commit/ca69d7800ae5635cca20a8804296acff6c749c14

------------------------------------------------------------------------
manuals/rebuild.sh: ensure SOURCE_DATE_EPOCH is always set

Support manual invocation of rebuild.sh, without depending on
debhelper or similar (which usually set SOURCE_DATE_EPOCH
accordingly).

Related to git rev c0039ea7b6

Closes: #1021520
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1021520

Message #13 received at 1021520-submitter@bugs.debian.org (full text, mbox, reply):

From: Michael Prokop <noreply@salsa.debian.org>

To: 1021520-submitter@bugs.debian.org

Subject: Bug#1021520 marked as pending in guymager

Date: Tue, 11 Oct 2022 05:39:21 +0000

Control: tag -1 pending

Hello,

Bug #1021520 in guymager reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/pkg-security-team/guymager/-/commit/075bf9fa3dc7e51d3501c229de352a9916257b07

------------------------------------------------------------------------
manuals/rebuild.sh: use SOURCE_DATE_EPOCH to set the date used for manpages

See https://reproducible-builds.org/docs/source-date-epoch/

Thanks: Vagrant Cascadian <vagrant@reproducible-builds.org> for the initial patch
Closes: #1021520
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1021520

Message #18 received at 1021520@bugs.debian.org (full text, mbox, reply):

From: Michael Prokop <mika@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 1021520@bugs.debian.org

Subject: Re: Bug#1021520: guymager: reproducible-builds: date in guymager manpage

Date: Tue, 11 Oct 2022 08:01:54 +0200

[Message part 1 (text/plain, inline)]

Hi Vagrant!

* Vagrant Cascadian [Sun Oct 09, 2022 at 05:41:19PM -0700]:

> The date is embedded in /usr/share/man/man1/guymager.1.gz:
> 
>   https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/guymager.html
> 
>   TH·guymager·1·"2023-11-10"·"version·0.8.13-1
>   vs.
>   TH·guymager·1·"2022-10-09"·"version·0.8.13-1
> 
> The attached patch to the upstream manuals/rebuild.sh file fixes this by
> using SOURCE_DATE_EPOCH to determine the date to embed in the manpage.
> 
> According to my local tests, with this patch applied guymager should
> build reproducibly on tests.reproducible-builds.org once it migrates to
> bookworm/testing! There are other outstanding issues with build-paths,
> which are only tested on unstable/experimental.

Thanks for your patch, Vagrant. I applied it and added another
change on top of yours, so manually invoking manuals/rebuild.sh
still works, and converted it into a quilt patch.

Would you mind taking a quick look at
https://salsa.debian.org/pkg-security-team/guymager/-/merge_requests/1
to check, whether this makes sense for you?
(The failing reprotest in the pipeline seems to come from the
guymager binary itself, AFAICS)

Thanks!

regards
-mika-

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 1021520@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Michael Prokop <mika@debian.org>, 1021520@bugs.debian.org

Subject: Re: Bug#1021520: guymager: reproducible-builds: date in guymager manpage

Date: Tue, 11 Oct 2022 09:04:09 -0700

[Message part 1 (text/plain, inline)]

On 2022-10-11, Michael Prokop wrote:
> * Vagrant Cascadian [Sun Oct 09, 2022 at 05:41:19PM -0700]:
>
>> The date is embedded in /usr/share/man/man1/guymager.1.gz:
>> 
>>   https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/guymager.html
>> 
>>   TH·guymager·1·"2023-11-10"·"version·0.8.13-1
>>   vs.
>>   TH·guymager·1·"2022-10-09"·"version·0.8.13-1
>> 
>> The attached patch to the upstream manuals/rebuild.sh file fixes this by
>> using SOURCE_DATE_EPOCH to determine the date to embed in the manpage.
>> 
>> According to my local tests, with this patch applied guymager should
>> build reproducibly on tests.reproducible-builds.org once it migrates to
>> bookworm/testing! There are other outstanding issues with build-paths,
>> which are only tested on unstable/experimental.
>
> Thanks for your patch, Vagrant. I applied it and added another
> change on top of yours, so manually invoking manuals/rebuild.sh
> still works, and converted it into a quilt patch.
>
> Would you mind taking a quick look at
> https://salsa.debian.org/pkg-security-team/guymager/-/merge_requests/1
> to check, whether this makes sense for you?

Nice! Looks good to me!

> (The failing reprotest in the pipeline seems to come from the
> guymager binary itself, AFAICS)

This is probably due to the build paths. I didn't figure out exactly
what was triggering that or how to avoid it in this case; it seemed to
be passing the -ffile-prefix-map build flag in at least some compiler
invocations, but maybe there are some corner-cases which ignore the
relevent *FLAGS variables. Long-term, it would be nice to avoid
embedding build paths too, but for now fixing at least timestamps will
help!

You can probably configure your salsa-ci reprotest job to exclude build
paths for now, as tests.reproducible-builds.org will catch that when
testing unstable or experimental:

  https://salsa.debian.org/salsa-ci-team/pipeline#adding-extra-arguments-to-reprotest

At least, until we figure that part out... :)

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 1021520-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1021520-close@bugs.debian.org

Subject: Bug#1021520: fixed in guymager 0.8.13-2

Date: Sat, 31 Dec 2022 11:36:59 +0000

Source: guymager
Source-Version: 0.8.13-2
Done: Michael Prokop <mika@debian.org>

We believe that the bug you reported is fixed in the latest version of
guymager, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1021520@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Prokop <mika@debian.org> (supplier of updated guymager package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 31 Dec 2022 12:01:22 +0100
Source: guymager
Architecture: source
Version: 0.8.13-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <team+pkg-security@tracker.debian.org>
Changed-By: Michael Prokop <mika@debian.org>
Closes: 1021520 1025562 1027270
Changes:
 guymager (0.8.13-2) unstable; urgency=medium
 .
   [ Michael Prokop ]
   * [075bf9f] manuals/rebuild.sh: use SOURCE_DATE_EPOCH to set the date
     used for manpages. Thanks to Vagrant Cascadian <vagrant@reproducible-
     builds.org> for the initial patch (Closes: #1021520)
   * [b23e201] No longer Build-Depend on libprocps-dev. Thanks to Peter
     Green + Craig Small (Closes: #1027270)
   * [ccbb11b] Recommend pkexec or policykit-1 (Closes: #1025562)
   * [83f2411] Bump Standards-Version to 4.6.2
 .
   [ Debian Janitor ]
   * [71ffccf] Use secure URI in Homepage field.
   * [b6f01ab] Bump debhelper from old 12 to 13.
   * [1182eb3] Update standards version to 4.6.1, no changes needed.
   * [87c3f48] Remove constraints unnecessary since buster (oldstable)
Checksums-Sha1:
 0e3f356dfb515dfac7d2f4db72bd205ba59137ae 2076 guymager_0.8.13-2.dsc
 1abe1eb4baf3170bb410244aeda9bae4ab416a6f 7600 guymager_0.8.13-2.debian.tar.xz
 5257438ea884840352fae6e9a3210c8994c5431a 10637 guymager_0.8.13-2_source.buildinfo
Checksums-Sha256:
 0c5512b7954a273de47478477d04c1e81dc045901472f7b9fdc3007a7ae08e2f 2076 guymager_0.8.13-2.dsc
 2321536ff7620d889c9b4efa76962536cc9f36e47c0e0ff6946f22456d496312 7600 guymager_0.8.13-2.debian.tar.xz
 1661c9fe2a104a989b6d15c9380eab1a478c7292916b955c7307c220b6dd507b 10637 guymager_0.8.13-2_source.buildinfo
Files:
 73c22209cd1c14c29811038d4ef3e5c4 2076 utils optional guymager_0.8.13-2.dsc
 0b7e0bec38d8aa8bc4c4a174170d45ab 7600 utils optional guymager_0.8.13-2.debian.tar.xz
 aca97166f170242652cdabae878b2556 10637 utils optional guymager_0.8.13-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEM8yxNkAa/shDo4djlqh4crfqNzcFAmOwGKYACgkQlqh4crfq
NzeWyA//ZQOsy7/7kuaBHfqvyk2hD/tNQl37FapAGYC6z+39pYco4hvIVDRfo6E6
1wsUHAgMEkDskTL7KKZpbLXtt5OQtAyyVeCfrLzMCyMmxNya8lMGW6J11xMZ7nND
wAZ/DU+BgXROERpNrnpHaKh/ulgtFRLK3vY1FapN7slCcdmKYLKX5JJH9O96sq3L
FKXRGqvBKI5Qo2hELzGll05FR13lN7jSl0q7PagcMoxXwLI6OKwZoZLku3WUymrK
OIv8FoeqsjysAEi5tCyo8w1sgc3ZuwzETOGXyBG7N4oEhlDtgglsgVTzWr2mqcTE
NiXAb+Y6zrVQUQpE329d16j6fPgOl68fCvhEn4zGhYGAcAYToUYz4PDoBbpJwYXg
/wanfhHAEPmGAb4qF6+poivBcmQ3Xsz4sBovE1qrE+jIOFmvj93j02lnM35g/4rr
+5z5oBi23QvSHRH+aAjxJKm9JXU938LyswqjJCBaTKzFccDMemRi4jhOe0H96ODt
plrLkw9wlwETVTNGaNx0Hu/6XrJbqUAzgL815ss/q6vnJ0gcoNgt3yndQpxEhuyN
89aq5WAIg5u9UnlaXU32SdAn+sn4nUAMSEUaUjG7euVDuh2vViKHwoF4ps97P1y6
z4Oe3mNXnsguwth611ZriCyuf7ZGCtzx3d0ZQhg1CtR1Q8YavmQ=
=xK2Y
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.