Debian Bug report logs - #1021514
ssocr: reproducible-builds: build path embedded in /usr/bin/ssocr

Package: src:ssocr; Maintainer for src:ssocr is Gürkan Myczko <tar@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Sun, 9 Oct 2022 23:18:01 UTC

Severity: normal

Tags: patch

Forwarded to https://github.com/auerswal/ssocr/issues/22

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Gürkan Myczko <tar@debian.org>:
Bug#1021514; Package src:ssocr. (Sun, 09 Oct 2022 23:18:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Gürkan Myczko <tar@debian.org>. (Sun, 09 Oct 2022 23:18:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: ssocr: reproducible-builds: build path embedded in /usr/bin/ssocr
Date: Sun, 09 Oct 2022 16:14:17 -0700
[Message part 1 (text/plain, inline)]
Source: ssocr
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/bin/ssocr:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/ssocr.html

  /build/1st/ssocr-2.22.1/ssocr.c:54
  vs.
  /build/2/ssocr-2.22.1/2nd/ssocr.c:54

The attached patch to debian/rules fixes this by adding a dh_auto_build
override that passes the default CFLAGS as CCOPTIONS.

According to my local tests, with this patch applied, ssocr should
*almost* build reproducibly on tests.reproducible-builds.org! (I'll
submit a patch also for the remaining timestamp issue)

Thanks for maintaining ssocr!

live well,
  vagrant
[0002-debian-rules-Add-dh_auto_build-override-to-explicitl.patch (text/x-diff, inline)]
From 085cdf7a5b78f15adf72cd5dcdfe4007874e5cd7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 9 Oct 2022 23:10:43 +0000
Subject: [PATCH 2/2] debian/rules: Add dh_auto_build override to explicitly
 pass the default CFLAGS.

---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index f864541..edda100 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,3 +13,6 @@ export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
 override_dh_auto_install:
 	@echo Do not use install target of upstream Makefile
+
+override_dh_auto_build:
+	dh_auto_build -- CFLAGS="$(CFLAGS)"
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Set Bug forwarded-to-address to 'https://github.com/auerswal/ssocr/issues/22'. Request was from Gürkan Myczko <gurkan@phys.ethz.ch> to control@bugs.debian.org. (Sun, 07 May 2023 18:36:03 GMT) (full text, mbox, link).


Information forwarded to debian-bugs-dist@lists.debian.org, Gürkan Myczko <tar@debian.org>:
Bug#1021514; Package src:ssocr. (Mon, 08 May 2023 12:45:03 GMT) (full text, mbox, link).


Acknowledgement sent to Erik Auerswald <auerswal@unix-ag.uni-kl.de>:
Extra info received and forwarded to list. Copy sent to Gürkan Myczko <tar@debian.org>. (Mon, 08 May 2023 12:45:03 GMT) (full text, mbox, link).


Message #12 received at 1021514@bugs.debian.org (full text, mbox, reply):

From: Erik Auerswald <auerswal@unix-ag.uni-kl.de>
To: 1021514@bugs.debian.org
Subject: Required compiler flags?
Date: Mon, 8 May 2023 14:35:31 +0200
Hi Vagrant,

this is the upstream ssocr developer.

Can you tell me which additional compiler flags are needed for a
reproducible build of ssocr?  Do they differ between GCC and LLVM?
Since when do the compiler flags exist?

Additionally, it might be helpful if the Debian build process can add
Debian- or platform-specific CFLAGS, e.g., enabling PIE on platforms that
support it.  As such I'd say that something like the patch attached to
your bug report might be useful, even if I added the respective compiler
options for reproducible builds to the upstream Makefile.

Thanks,
Erik
-- 
Be water, my friend.
                        -- Bruce Lee



Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 12:42:47 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.