Debian Bug report logs - #1021470
xsok: reproducible-builds: build path embedded in /usr/games/xsok

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: xsok: reproducible-builds: build path embedded in /usr/games/xsok

Date: Sat, 08 Oct 2022 18:25:11 -0700

[Message part 1 (text/plain, inline)]

Source: xsok
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/games/xsok:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xsok.html

  /build/1st/xsok-1.02/src/Xaw-main.c:273
  vs.
  /build/2/xsok-1.02/2nd/src/Xaw-main.c:273

The attached patch to debian/rules fixes this by passing to make the
default CFLAGS using the upstream CCOPTIONS variable.

According to my local tests, with this patch applied, xsok should build
reproducibly on tests.reproducible-builds.org!

Thanks for maintaining xsok!

live well,
  vagrant

[0001-debian-rules-Pass-default-CFLAGS-via-CCOPTIONS-varia.patch (text/x-diff, inline)]

From 61246f44398cd2537268920502a906aa99f8233c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 9 Oct 2022 01:21:33 +0000
Subject: [PATCH] debian/rules: Pass default CFLAGS via CCOPTIONS variable.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 216e53d..fc9561e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -15,7 +15,7 @@ build-indep: build
 build: build-stamp
 build-stamp:
 	dh_testdir
-	$(MAKE) $(OPTIMIZE) \
+	$(MAKE) CCOPTIONS="$(shell dpkg-buildflags --get CFLAGS)" $(OPTIMIZE) \
 	  LOCAL_LIBRARIES='-lXpm -lXaw -lXt -lX11' \
 	  XSOKLIBDIR=/usr/share/games/xsok \
 	  XSOKSAVEDIR=/var/games/xsok
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.