Debian Bug report logs - #1020725
snapper: reproducible-builds: Embedded build path in example Makefile

Package: src:snapper; Maintainer for src:snapper is Hideki Yamane <henrich@debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Sun, 25 Sep 2022 20:03:02 UTC

Severity: normal

Tags: patch

Reply or subscribe to this bug.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Hideki Yamane <henrich@debian.org>:
Bug#1020725; Package src:snapper. (Sun, 25 Sep 2022 20:03:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Hideki Yamane <henrich@debian.org>. (Sun, 25 Sep 2022 20:03:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: snapper: reproducible-builds: Embedded build path in example Makefile
Date: Sun, 25 Sep 2022 13:01:01 -0700
[Message part 1 (text/plain, inline)]
Source: snapper
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in
/usr/share/doc/libsnapper-dev/examples/Makefile:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/snapper.html

  ACLOCAL·=·${SHELL}·'/build/1st/snapper-0.10.2/missing'·aclocal-1.16
  vs.
  ACLOCAL·=·${SHELL}·'/build/2/snapper-0.10.2/2nd/missing'·aclocal-1.16

The attached patch fixes this in debian/rules by removing the Makefile
in a dh_installexamples override. Removing the Makefile seems better
than sanitizing the build path, as in order to use it, one would have to
regenerate it from the provided Makefile.in or Makefile.am to match the
running system.

With this patch applied (and another recently submitted to fix usrmerge
issues) snapper should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining snapper!

live well,
  vagrant
[0002-debian-rules-Add-dh_installexamples-override-to-remo.patch (text/x-diff, inline)]
From bfce7a9e7d00177d4ff7c3b5e4e9a12457d49149 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 25 Sep 2022 19:37:56 +0000
Subject: [PATCH 2/2] debian/rules: Add dh_installexamples override to remove
 an example Makefile containing build paths.

This file may need to be regenerated from Makefile.am or Makefile.in
to match the system on which it is being run.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/debian/rules b/debian/rules
index 241b9bb..161bad8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -36,6 +36,11 @@ override_dh_auto_install:
 	# Cleanup examples
 	make -C examples clean
 
+override_dh_installexamples:
+	dh_installexamples
+	# Remove example Makefile which contains build path for reproducible builds
+	rm -f debian/libsnapper-dev/usr/share/doc/libsnapper-dev/examples/Makefile
+
 override_dh_compress:
 	dh_compress -X.c -X.cc -X.h -X.hpp -X.am
 
-- 
2.37.2

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 13:28:07 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.