Debian Bug report logs - #1020153
magit: FTBFS: make[2]: *** [Makefile:111: test] Error 255

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Lucas Nussbaum <lucas@debian.org>

To: submit@bugs.debian.org

Subject: magit: FTBFS: make[2]: *** [Makefile:111: test] Error 255

Date: Sun, 18 Sep 2022 08:55:08 +0200

Source: magit
Version: 3.3.0-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20220917 ftbfs-bookworm

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> make[2]: Entering directory '/<<PKGBUILDDIR>>'
> Loading /<<PKGBUILDDIR>>/t/magit-tests.el (source)...
> Debugger entered--Lisp error: (error "Cannot find suitable directory for output in ‘nati...")
>   error("Cannot find suitable directory for output in `nati...")
>   comp-trampoline-compile(abort-recursive-edit)
>   comp-subr-trampoline-install(abort-recursive-edit)
>   advice--add-function(:before (#f(compiled-function () #<bytecode 0x32e14019df7e91>) . #f(compiled-function (gv--val) #<bytecode 0x9f608bbba7cb3c2>)) transient--abort-edebug nil)
>   advice-add(abort-recursive-edit :before transient--abort-edebug)
>   load-with-code-conversion("/usr/share/emacs/site-lisp/elpa-src/transient-0.3...." "/usr/share/emacs/site-lisp/elpa-src/transient-0.3...." nil t)
>   require(transient)
>   load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit-mode.el" "/<<PKGBUILDDIR>>/lisp/magit-mode.el" nil t)
>   require(magit-mode)
>   load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit-core.el" "/<<PKGBUILDDIR>>/lisp/magit-core.el" nil t)
>   require(magit-core)
>   load-with-code-conversion("/<<PKGBUILDDIR>>/lisp/magit.el" "/<<PKGBUILDDIR>>/lisp/magit.el" nil t)
>   require(magit)
>   load-with-code-conversion("/<<PKGBUILDDIR>>/t/magit-tests.el" "/<<PKGBUILDDIR>>/t/magit-tests.el" nil nil)
>   load-file("t/magit-tests.el")
>   (progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-exit))
>   command-line-1(("-L" "./lisp" "-L" "/usr/share/emacs/site-lisp/elpa-src/dash-2.19.1" "-L" "./../libgit" "-L" "/usr/share/emacs/site-lisp/elpa-src/transient-0.3...." "-L" "/usr/share/emacs/site-lisp/elpa-src/with-editor-3...." "--eval" "(progn        (load-file \"t/magit-tests.el\")(ert-r..."))
>   command-line()
>   normal-top-level()
> 
> make[2]: *** [Makefile:111: test] Error 255


The full build log is available from:
http://qa-logs.debian.net/2022/09/17/magit_3.3.0-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220917;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220917&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Message #10 received at 1020153@bugs.debian.org (full text, mbox, reply):

From: intrigeri <intrigeri@debian.org>

To: 1020153@bugs.debian.org

Subject: Re: Bug#1020153: magit: FTBFS: make[2]: *** [Makefile:111: test] Error 255

Date: Tue, 22 Nov 2022 09:24:37 +0100

[Message part 1 (text/plain, inline)]

Hi,

I ended up here after realizing that a bunch of Emacs packages I use
got removed from testing due to this bug.

Lucas Nussbaum (2022-09-18):
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
>
>
> Relevant part (hopefully):
>> make[2]: Entering directory '/<<PKGBUILDDIR>>'
>> Loading /<<PKGBUILDDIR>>/t/magit-tests.el (source)...
>> Debugger entered--Lisp error: (error "Cannot find suitable directory for output in ‘nati...")
>>   error("Cannot find suitable directory for output in `nati...")
>>   comp-trampoline-compile(abort-recursive-edit)

I can reproduce this with sbuild, but not with pbuilder.

It seems to belong the same class of errors that was fixed in dh-elpa with
https://salsa.debian.org/emacsen-team/dh-elpa/-/commit/d80ee7a8a159f20316640ec9e6a928e3c57d3f6e

But magit's debian/rule has override_dh_elpa_test, so we don't benefit
from the dh-elpa fix.

The attached patch replicates the dh-elpa fix in t/magit-tests.el,
which fixes the problem allows running the test suite.

Unfortunately, 2/20 tests fail, so the attached patch won't fit the
FTBFS (which is why I'm not tagging this "patch"):

Loading /<<PKGBUILDDIR>>/t/magit-tests.el (source)...
Cannot determine Magit’s version (error "/<<PKGBUILDDIR>>/lisp/magit.el" repo static elpa dirname hash)
Running 20 tests (2022-11-22 08:13:25+0000, selector ‘t’)
   passed   1/20  magit--with-safe-default-directory (0.015131 sec)
Keeping test directory:
  /tmp/magit-TDFbME/
Test magit-get backtrace:
  signal(magit-git-error ("clone of '/tmp/magit-TDFbME/remote' into su
  (condition-case err (let* ((vnew #'(lambda (&rest _))) (old (symbol-
  (let ((dir (file-name-as-directory (make-temp-file "magit-" t))) (pr
  (let ((lexical-binding nil)) (let ((dir (file-name-as-directory (mak
  (lambda nil (let ((lexical-binding nil)) (let ((dir (file-name-as-di
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name magit-get :documentation nil :body (l
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [... ... ... 
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  (progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-exit)
  command-line-1(("-L" "./lisp" "-L" "/usr/share/emacs/site-lisp/elpa-
  command-line()
  normal-top-level()
Test magit-get condition:
    (magit-git-error "clone of '/tmp/magit-TDFbME/remote' into submodule path '/tmp/magit-TDFbME/super/repo' failed (in /tmp/magit-TDFbME/super/)")
   FAILED   2/20  magit-get (0.708641 sec)
   passed   3/20  magit-get-boolean (0.199891 sec)
   passed   4/20  magit-get-{current|next}-tag (0.749619 sec)
   passed   5/20  magit-in-bare-repo (0.071072 sec)
   passed   6/20  magit-in-non-bare-repo (0.080570 sec)
   passed   7/20  magit-list-{|local-|remote-}branch-names (0.366282 sec)
   passed   8/20  magit-process:match-prompt-match-non-first-prompt (0.000091 sec)
   passed   9/20  magit-process:match-prompt-nil-when-no-match (0.000065 sec)
   passed  10/20  magit-process:match-prompt-non-nil-when-match (0.000061 sec)
   passed  11/20  magit-process:match-prompt-preserves-match-group (0.000111 sec)
   passed  12/20  magit-process:match-prompt-suffixes-prompt (0.000098 sec)
   passed  13/20  magit-process:password-prompt (0.000111 sec)
   passed  14/20  magit-process:password-prompt-observed (0.001084 sec)
   passed  15/20  magit-status:file-sections (0.868935 sec)
   passed  16/20  magit-status:log-sections (0.907880 sec)
   passed  17/20  magit-toplevel:basic (0.245211 sec)
Keeping test directory:
  /tmp/magit-6jLVvi/
Test magit-toplevel:submodule backtrace:
  signal(magit-git-error ("clone of '/tmp/magit-6jLVvi/remote' into su
  (condition-case err (let* ((vnew #'(lambda (&rest _))) (old (symbol-
  (let ((dir (file-name-as-directory (make-temp-file "magit-" t))) (pr
  (let ((find-file-visit-truename nil)) (let ((dir (file-name-as-direc
  (let ((lexical-binding nil)) (let ((find-file-visit-truename nil)) (
  (lambda nil (let ((lexical-binding nil)) (let ((find-file-visit-true
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name magit-toplevel:submodule :documentati
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests ... :test-map
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  (progn (load-file "t/magit-tests.el") (ert-run-tests-batch-and-exit)
  command-line-1(("-L" "./lisp" "-L" "/usr/share/emacs/site-lisp/elpa-
  command-line()
  normal-top-level()
Test magit-toplevel:submodule condition:
    (magit-git-error "clone of '/tmp/magit-6jLVvi/remote' into submodule path '/tmp/magit-6jLVvi/super/repo' failed (in /tmp/magit-6jLVvi/super/)")
   FAILED  18/20  magit-toplevel:submodule (0.249347 sec)
   passed  19/20  magit-toplevel:tramp (1.286620 sec)
   passed  20/20  magit-utils:add-face-text-property (0.000050 sec)

Ran 20 tests, 18 results as expected, 2 unexpected (2022-11-22 08:13:31+0000, 6.072702 sec)

2 unexpected results:
   FAILED  magit-get
   FAILED  magit-toplevel:submodule

I feel I'm out of my depth to investigate this further.

Cheers,
-- 
intrigeri

[0005-disable-native-compilation-in-tests.patch (text/x-diff, inline)]

--- a/t/magit-tests.el
+++ b/t/magit-tests.el
@@ -6,6 +6,8 @@
 
 ;;; Code:
 
+(setq native-comp-deferred-compilation nil comp-enable-subr-trampolines nil)
+
 (require 'cl-lib)
 (require 'dash)
 (require 'ert)

Message #15 received at 1020153-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1020153-close@bugs.debian.org

Subject: Bug#1020153: fixed in magit 3.3.0-2

Date: Sat, 24 Dec 2022 19:49:45 +0000

Source: magit
Source-Version: 3.3.0-2
Done: Sean Whitton <spwhitton@spwhitton.name>

We believe that the bug you reported is fixed in the latest version of
magit, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1020153@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sean Whitton <spwhitton@spwhitton.name> (supplier of updated magit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 24 Dec 2022 12:23:59 -0700
Source: magit
Architecture: source
Version: 3.3.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Emacsen team <debian-emacsen@lists.debian.org>
Changed-By: Sean Whitton <spwhitton@spwhitton.name>
Closes: 1020153
Changes:
 magit (3.3.0-2) unstable; urgency=medium
 .
   [ Aymeric Agon-Rambosson ]
   * Add myself, Aymeric Agon-Rambosson, to Uploaders.
   * Add repair-magit-get-and-submodule-tests.patch.
   * Add repair-git-unable-to-detect-address.patch (Autopkgtest).
   * Add Bug-Submit field to d/upstream/metadata.
 .
   [ Sean Whitton ]
   * Team upload.
   * override_dh_elpa_test: Export EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION=t
     (Closes: #1020153).
     - Add build-dep on emacs-nox|emacs >= 1:28.2+1-9.
Checksums-Sha1:
 da862291d68c7f05851cacfd67d678c6f36fec12 2382 magit_3.3.0-2.dsc
 cbfc98073cf2655f4a4545dd5b9e5494db07b98c 9736 magit_3.3.0-2.debian.tar.xz
Checksums-Sha256:
 32a51b317407026b997ee4f936257b44c1e6f6dc029058cd1e3b0334174901f9 2382 magit_3.3.0-2.dsc
 b5c53e36db3b153736f2b8885512589c93280c155e9a88f76dff99ac5d62a385 9736 magit_3.3.0-2.debian.tar.xz
Files:
 fcf9c4e3935bdf7eea653df9ca168926 2382 vcs optional magit_3.3.0-2.dsc
 0f6cbf680aaa07725a20b31745202997 9736 vcs optional magit_3.3.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmOnUpQACgkQaVt65L8G
YkDtvw//c4EpaKhnvozD9/RT5912irwrz1XUPRFd/kwHJ3iD7L+c+z2wjsKRLll/
NTlC93t8Q+/UWUyUX4Let+Zy7JeWO3el6dAJLEvLoMHpAofgcxzgpDBKT9O/O8Yu
WDjK7esppxQqSFjYLfqYY0clvZ5FhBVPwq373OSaJ7IBs2ZXAfNpEA87jczZwcLY
+HRFU4V/tKTObSipnmJr8tCkf810CR9rC0Zea+0oFt3Fs10LgjwxNszs2EuHOoN9
Ke2q3nvfGizSwjC8c5Fu/lIZgxn/fLTZ8Lf485ZBhAqGB0yVhpvoGDKdSWOQFzHS
q/E5QdFXUX4ESF80QSm6f5xX2LJWTJ8xUdfQZCUL92RjlDBrFBiQ4YdTM4kDwSZf
fRcqxUzfj3qmEimNyb13kDbLemUjGU9EWXcce3jBtb+jnBG+6yscsOHjX7bWMjRX
BtURXngJVoIJ+fA7RT6Yl9Ym3F/MTAX/xWJLcaPpW6Cncfw0n+VDbjqjgEsmM+H2
bvYc7F2SyUbl75llxgquCIl2WbPCWlk2t1QcXGHcF8NBY3Oyz5MSMy45FGeJrDUp
ixyDlRngxwnTl4S7dkSc28A4vcLKi5dgMHUOzwrOoDw1mI1ani7zVMMv0lNanqrI
P1k7DF5XQx4ThQYHg4Vp6MG6snCIWMWlPiwxFncUxXYNYbtbFM8=
=C6Ju
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.