Debian Bug report logs - #1019499
rlottie: invisible animation with separated layers

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: bebrabox <reallynotarmitage@gmail.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: telegram-desktop: High CPU usage (up to 100%), invisible message reactions and problems with animated stickers

Date: Thu, 25 Aug 2022 03:26:07 +0300

Package: telegram-desktop
Version: 4.1.1+ds-1
Severity: normal

Dear Maintainer,

After one of the updates message reactions became invisible
(if there are lots of reactions 1 or 2 can be visible).
It didn't really matter and I thought this bug would go away
on its own (or after next update). But then I noticed that 
there also were issues with animated stickers (some of them
also disappear, some of them freeze).

Short investigation showed that CPU usage was rising after
looking at animated stickers (either by getting them from
other people or by trying to send them). CPU usage was 
rising up to 100% and hung up the system. Build from telegram's 
official site didn't have this issues.

Hope you will find my report useful

-- Package-specific info:

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.18.0-4-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages telegram-desktop depends on:
ii  libabsl20210324                                     0~20210324.2-4
ii  libavcodec59                                        7:5.1-2+b1
ii  libavformat59                                       7:5.1-2+b1
ii  libavutil57                                         7:5.1-2+b1
ii  libc6                                               2.34-4
ii  libgcc-s1                                           12.2.0-1
ii  libglib2.0-0                                        2.73.3-2
ii  libglibmm-2.4-1v5                                   2.66.4-1
ii  libhunspell-1.7-0                                   1.7.1-1
ii  libjpeg62-turbo                                     1:2.1.2-1
ii  liblz4-1                                            1.9.3-2
ii  libminizip1                                         1.1-8+b1
ii  libopenal1                                          1:1.19.1-2
ii  libopus0                                            1.3.1-2
ii  libqrcodegencpp1                                    1.8.0-1.1
ii  libqt5core5a [qtbase-abi-5-15-4]                    5.15.4+dfsg-5
ii  libqt5gui5                                          5.15.4+dfsg-5
ii  libqt5network5                                      5.15.4+dfsg-5
ii  libqt5svg5                                          5.15.4-2
ii  libqt5waylandclient5 [qtwayland-client-abi-5-15-4]  5.15.4-2
ii  libqt5widgets5                                      5.15.4+dfsg-5
ii  librlottie0-1                                       0.1+dfsg-3
ii  libsigc++-2.0-0v5                                   2.10.8-1
ii  libssl3                                             3.0.5-2
ii  libstdc++6                                          12.2.0-1
ii  libswresample4                                      7:5.1-2+b1
ii  libswscale6                                         7:5.1-2+b1
ii  libvpx7                                             1.12.0-1
ii  libwayland-client0                                  1.21.0-1
ii  libx11-6                                            2:1.8.1-2
ii  libxcb-keysyms1                                     0.4.0-1+b2
ii  libxcb-record0                                      1.15-1
ii  libxcb-screensaver0                                 1.15-1
ii  libxcb1                                             1.15-1
ii  libxcomposite1                                      1:0.4.5-1
ii  libxdamage1                                         1:1.1.5-2
ii  libxext6                                            2:1.3.4-1
ii  libxfixes3                                          1:6.0.0-1
ii  libxrandr2                                          2:1.5.2-2+b1
ii  libxtst6                                            2:1.2.3-1.1
ii  libxxhash0                                          0.8.1-1
ii  qt5-image-formats-plugins                           5.15.4-2
ii  zlib1g                                              1:1.2.11.dfsg-4.1

Versions of packages telegram-desktop recommends:
ii  fonts-open-sans       1.11-2
ii  libwebkit2gtk-4.0-37  2.36.6-1
ii  libwebkit2gtk-4.1-0   2.36.6-1

telegram-desktop suggests no packages.

Versions of packages telegram-desktop is related to:
ii  xdg-desktop-portal          1.14.6-1
pn  xdg-desktop-portal-backend  <none>

-- debconf-show failed

Message #10 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Alexander Kernozhitsky <sh200105@mail.ru>

To: 1018065@bugs.debian.org

Subject: Patch for high CPU usage

Date: Thu, 01 Sep 2022 04:07:01 +0300

Control: tags -1 patch

I think it would be better to split the bug into separate independent reports, 
as the current bug report describes many regressions at once, each with a 
potentially different cause.

Regarding high CPU usage, I spent some time in GDB and found the root
cause. I made a patch and opened a pull request with it against the upstream:

https://github.com/telegramdesktop/tdesktop/pull/25012

After rebuilding the app with this patch, I noticed that the app stopped using 
CPU intensively in the background.

-- 
Alexander Kernozhitsky

Message #17 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Alexander Kernozhitsky <sh200105@mail.ru>

To: 1018065@bugs.debian.org

Subject: On disappeared reactions and animated stickers

Date: Fri, 02 Sep 2022 11:48:42 +0300

I experimented a little and noticed that the latter two bugs (i.e. the ones 
with missing reactions and stickers) can be fixed if Telegram is built with 
patched rlottie instead of using the one shipped as a Debian package. I didn't 
dig into details on how to fix this in Debian version of rlottie.

-- 
Alexander Kernozhitsky

Message #22 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Nicholas Guriev <nicholas@guriev.su>

To: Alexander Kernozhitsky <sh200105@mail.ru>, 1018065@bugs.debian.org

Subject: Re: Bug#1018065: On disappeared reactions and animated stickers

Date: Sat, 03 Sep 2022 13:25:09 +0300

[Message part 1 (text/plain, inline)]

Alexander Kernozhitsky, thank you for many clarifications. Can you please 
extract somehow the buggy sticker (animation)? So that the bug in rLottie 
could be fixed. If you do not know which particular sticker causes the glitch, 
point out the problem sticker set.

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Alexander Kernozhitsky <sh200105@mail.ru>

To: 1018065@bugs.debian.org

Subject: Re: Bug#1018065: On disappeared reactions and animated stickers

Date: Sat, 03 Sep 2022 17:35:57 +0300

Hello.

> Alexander Kernozhitsky, thank you for many clarifications. Can you please
> extract somehow the buggy sticker (animation)? So that the bug in rLottie
> could be fixed. If you do not know which particular sticker causes the
> glitch, point out the problem sticker set.

I hope that the following channel will help you to reproduce all the three 
bugs: https://t.me/bug1018065.

Note that the reactions are not shown also.

Unfortunately, I don't know how to export a sticker from Telegram, so cannot 
do it myself.

-- 
Alexander Kernozhitsky

Message #32 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Nicholas Guriev <nicholas@guriev.su>

To: Alexander Kernozhitsky <sh200105@mail.ru>, 1018065@bugs.debian.org

Subject: Re: Bug#1018065: On disappeared reactions and animated stickers

Date: Sat, 03 Sep 2022 20:15:49 +0300

[Message part 1 (text/plain, inline)]

Thank you for the reproducer. I am investigating the issue. I noticed that
with the librlottie0-1 package of version 0.1+dfsg-2 tdesktop is able to
render all the stickers and the reactions there.

You can find the previous version of rLottie at the snapshot.d.o site.
https://snapshot.debian.org/package/rlottie/0.1%2Bdfsg-2/#librlottie0-1_0.1:2b:dfsg-2

I was trying to work around other crashes in the -3 revision. But apparently,
the regression seeped. 😓

Although, a certain thread in tdesktop still hangs after opening the channel.
This can be related to FFmpeg. I will apply the patch from your PR on GitHub.

On 03.09.2022 17:35:57 MSK you wrote:
> Unfortunately, I don't know how to export a sticker from Telegram, so cannot
> do it myself.

By the way, you can download any sticker from context menu on right-click,
with the item "Save as..." there.

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Alexander Kernozhitsky <sh200105@mail.ru>

To: 1018065@bugs.debian.org

Subject: Re: Bug#1018065: On disappeared reactions and animated stickers

Date: Sat, 03 Sep 2022 20:23:00 +0300

> Although, a certain thread in tdesktop still hangs after opening the
> channel. This can be related to FFmpeg. I will apply the patch from your PR
> on GitHub.
Yep, the hanging thread issue can be fixed with the patch from the PR.

> > Unfortunately, I don't know how to export a sticker from Telegram, so
> > cannot do it myself.
> 
> By the way, you can download any sticker from context menu on right-click,
> with the item "Save as..." there.
Thanks :) I didn't know about this feature before.

-- 
Alexander Kernozhitsky

Message #42 received at 1018065@bugs.debian.org (full text, mbox, reply):

From: Nicholas Guriev <nicholas@guriev.su>

To: 1018065@bugs.debian.org

Subject: Re: Bug#1018065: On disappeared reactions and animated stickers

Date: Sat, 10 Sep 2022 18:24:41 +0300

[Message part 1 (text/plain, inline)]

clone 1018065 -2
reassign -2 librlottie0-1 0.1+dfsg-3
retitle -2 rlottie: invisible animation with separated layers
retitle 1018065 telegram-desktop: dangling decoding threads due to video stickers
thanks

Hi, everyone interested!

I am splitting this bug report into two as Alexander Kernozhitsky suggested.
Because the problems need to be fixed in different packages.

For disappeared reactions and invisible animated stickers, I already have a
fix. It was due to wrong check in my No-cyclic-structures.patch. As for
incorrect FFmpeeg usage, it will be fixed in the upcoming Telegram release.

[signature.asc (application/pgp-signature, inline)]

Message #57 received at 1019499-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1019499-close@bugs.debian.org

Subject: Bug#1019499: fixed in rlottie 0.1+dfsg-4

Date: Mon, 12 Sep 2022 20:42:03 +0000

Source: rlottie
Source-Version: 0.1+dfsg-4
Done: Nicholas Guriev <guriev-ns@ya.ru>

We believe that the bug you reported is fixed in the latest version of
rlottie, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1019499@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicholas Guriev <guriev-ns@ya.ru> (supplier of updated rlottie package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 10 Sep 2022 18:49:38 +0300
Source: rlottie
Architecture: source
Version: 0.1+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: Nicholas Guriev <guriev-ns@ya.ru>
Changed-By: Nicholas Guriev <guriev-ns@ya.ru>
Closes: 1018725 1019499
Changes:
 rlottie (0.1+dfsg-4) unstable; urgency=medium
 .
   * Update No-cyclic-structures.patch (Closes: #1019499).
     - Move check of layer self-nesting to parsing stage from rendering.
   * Rewrite Atomic-render.patch (Closes: #1018725).
     - Use non-blocking std::atomic_flag instead of std::atomic_bool, because
       the flag does not require linking against libatomic on RISC-V 64bit.
Checksums-Sha1:
 1b7148f5675df2c75873682aeff5519aa22fc5a5 2023 rlottie_0.1+dfsg-4.dsc
 fabda403a0d0871579c5fb2da98e741c3d7ea370 21184 rlottie_0.1+dfsg-4.debian.tar.xz
Checksums-Sha256:
 a8e26aedc79610b9f3100208234c3c490d1b9c7491828d4eec99c8840e72431f 2023 rlottie_0.1+dfsg-4.dsc
 2894e2aacc0684683fcf35e587c221af143682af9467bea11328769cbc6ae8e8 21184 rlottie_0.1+dfsg-4.debian.tar.xz
Files:
 85c0cb7dbe132cf6b2bb885c406b7209 2023 libs optional rlottie_0.1+dfsg-4.dsc
 c70947c90e86c4d972d6d1a728d7af4c 21184 libs optional rlottie_0.1+dfsg-4.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEERoDLeOit93I/iGLK2bXpN3piwCsFAmMfjv4ACgkQ2bXpN3pi
wCtchA/+I40Nob8idtNAiS5YfGJ1lLwT5umlDXBYA4u7sXCTPLXfFFHOsMVnuk4j
EpxH2XXoCKqO/Nx3DxFDFIvpCJrEdtq9IQ/OA4bC5f7Gs068DWzZefGI3ncACQrX
3VssM2Cnqjw+b/BhPCQDZ32DrEr4YW6g+IOpAKqmXpixcNugBrPLhWsWsM6oyRed
ojxFHQbEKtbfn9M7RybIEfsfdyWCCdN0/FJeX/5FhYV9yNBQa9wntXgVKcy9MT9C
CnUGgDa1iIeBJR3zEGGCnZ8ZSm6UcZogF/sWklQg85b0PDyb1RQFO1rI6jsf9SKD
R1tOwIZt/hAjPtyVjSIDYOtu4MQ7ziTkfIuUXpEbMzSBS4B7xNcvHQTvpXar+R0k
twbIem8Dz89DIhyGnI3RgW6g3unDf6ulOfAU/2cMqspE3mr7w428Rct0XaiH4Prg
uqLw2sLJfvHww6DIqyTCsX1xD1aJUGgETirdAFWSZsv13IDe2lAf3e0rAA101tXL
6uXkoZbEinZ7GSIG6585J3KtCutBw30WS/51mwr3pToz9rM1DAy+1NXf20T03vk4
AqkD5NgYRwXGQV3Q9TFMxEOJhL7JL7RT3DmAFPeCPd1ghJNgLjBTltqGCHxOfRHi
pDaVb9035CJGMkpRbf6qZX11gGKhKCSPzr429pJ06oyAu0qiPpM=
=I1+G
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.