Debian Bug report logs - #1011500
tuxcmd-modules: reproducible-builds: embedded build paths in various binaries

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: tuxcmd-modules: reproducible-builds: embedded build paths in various binaries

Date: Mon, 23 May 2022 17:47:11 -0700

[Message part 1 (text/plain, inline)]

Source: tuxcmd-modules
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in various binaries in /usr/lib:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/tuxcmd-modules.html

  /usr/lib/tuxcmd/libarchive_plugin.so

  /build/1st/tuxcmd-modules-0.6.70+ds/libarchive/strutils.c:27
  vs.
  /build/2/tuxcmd-modules-0.6.70+ds/2nd/libarchive/strutils.c:27

The attached patch fixes this by adjusting various Makefiles to set
-ffile-prefix-map in CFLAGS, which avoids embedding the build path in
the compiled binaries.


With this patch applied, tuxcmd-modules should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant

[0001-Support-passing-ffile-prefix-map-in-various-Makefile.patch (text/x-diff, inline)]

From 0bd222e5cf0c9710c97c217fce4d0435cee989bc Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 24 May 2022 00:39:56 +0000
Subject: [PATCH] Support passing -ffile-prefix-map in various Makefiles.

This avoids embedding the build path in the resulting binaries.

https://reproducible-builds.org/docs/build-path/
---
 Makefile                | 2 ++
 gvfs/Makefile           | 2 ++
 libarchive/Makefile     | 3 +++
 zip/Makefile            | 2 ++
 zip/Makefile.ziparch    | 3 +++
 zip/ZipArchive/Makefile | 3 +++
 6 files changed, 15 insertions(+)

diff --git a/Makefile b/Makefile
index 61dade4..2d78375 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,7 @@
 SUBDIRS = zip libarchive gvfs
 
+export BUILDPATH = $(CURDIR)
+
 all install clean shared static::
 	target=`echo $@ | sed s/-recursive//`; \
 	list='$(SUBDIRS)'; for subdir in $$list; do \
diff --git a/gvfs/Makefile b/gvfs/Makefile
index 9c5d759..8bd0c08 100644
--- a/gvfs/Makefile
+++ b/gvfs/Makefile
@@ -9,6 +9,8 @@ CFLAGS =-I. -I/usr/include \
 	-Wall -fPIC -O2 -g \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
 
+# Avoid embedding build path
+CFLAGS += -ffile-prefix-map=$(BUILDPATH)=.
 
 # VFS_COMMON_OBJECTS=strutils.o treepathutils.o treepath_vfs.o vfsutils.o
 VFS_COMMON_OBJECTS=
diff --git a/libarchive/Makefile b/libarchive/Makefile
index 8514968..db3c1b5 100644
--- a/libarchive/Makefile
+++ b/libarchive/Makefile
@@ -13,6 +13,9 @@ CFLAGS =-I. -I/usr/include -I$(DIR_COMMON) \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE \
 	-D__VERBOSE_DEBUGx
 
+# Avoid embedding build path
+CFLAGS += -ffile-prefix-map=$(BUILDPATH)=.
+
 VFS_COMMON_OBJECTS=strutils.o treepathutils.o treepath_vfs.o vfsutils.o
 
 VFS_OBJECTS=libarchive.o
diff --git a/zip/Makefile b/zip/Makefile
index 1299323..5d32373 100644
--- a/zip/Makefile
+++ b/zip/Makefile
@@ -12,6 +12,8 @@ CFLAGS =-I. -I$(DIR_ZIPARCHIVE) -I/usr/include \
 	-DG_DISABLE_DEPRECATED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE \
 	-D__VERBOSE_DEBUGx
 
+# Avoid embedding build path
+CFLAGS += -ffile-prefix-map=$(BUILDPATH)=.
 
 VFS_COMMON_OBJECTS=strutils.o treepathutils.o treepath_vfs.o vfsutils.o
 
diff --git a/zip/Makefile.ziparch b/zip/Makefile.ziparch
index 2a66b94..ab8db23 100644
--- a/zip/Makefile.ziparch
+++ b/zip/Makefile.ziparch
@@ -19,6 +19,9 @@ CCC=cc
 CFLAGS = -D ZIP_ARCHIVE_LNX -fPIC -g -O2
 #CFLAGS =
 
+# Avoid embedding build path
+CFLAGS += -ffile-prefix-map=$(BUILDPATH)=.
+
 ifdef INTERNAL_BZIP2
 CFLAGS += -D ZIP_ARCHIVE_BZIP2_INTERNAL 
 endif
diff --git a/zip/ZipArchive/Makefile b/zip/ZipArchive/Makefile
index a426b6d..627b036 100644
--- a/zip/ZipArchive/Makefile
+++ b/zip/ZipArchive/Makefile
@@ -23,6 +23,9 @@ ifdef INTERNAL_BZIP2
 CFLAGS += -D ZIP_ARCHIVE_BZIP2_INTERNAL
 endif
 
+# Avoid embedding build path
+CFLAGS += -ffile-prefix-map=$(BUILDPATH)=.
+
 ZIPARCHLIB = libziparch.a
 
 ZIPPIELOCATION = ../Zippie/
-- 
2.36.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1011500@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 1011500@bugs.debian.org, 1011500-submitter@bugs.debian.org, 941296@bugs.debian.org, 941296-submitter@bugs.debian.org

Subject: Re: tuxcmd-modules: reproducible-builds: embedded build paths in various binaries

Date: Thu, 17 Nov 2022 17:23:06 +0000

[Message part 1 (text/plain, inline)]

tags 1011500 + pending patch
tags 941296 + pending patch
thanks

I've just uploaded tuxcmd-modules 0.6.70+ds-5.1 to DELAYED/10:
  
  tuxcmd-modules (0.6.70+ds-5.1) unstable; urgency=medium
  .
    * Non-maintainer upload.
    * Apply a patch by Vagrant Cascadian to ensure that tuxcmd-modules does not
      embed build paths in various binaries. (Closes: #1011500)
    * Apply a patch by Helmut Grohne to make it possible to cross-build
      tuxcmd-modules. (Closes: #941296)

The full debdiff is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[tuxcmd-modules_0.6.70+ds-5.1_amd64.debdiff.txt (text/plain, attachment)]

Message #20 received at 1011500@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: 1011500@bugs.debian.org, 1011500-submitter@bugs.debian.org, 941296@bugs.debian.org, 941296-submitter@bugs.debian.org

Subject: Re: tuxcmd-modules: reproducible-builds: embedded build paths in various binaries

Date: Fri, 18 Nov 2022 07:47:43 +0000

[Message part 1 (text/plain, inline)]

tags 1011500 + pending patch
thanks

I've just uploaded an updated version of tuxcmd-modules 0.6.70+ds-5.1
to DELAYED/3. This variant of the upload actually includes the fix for
#941296 which was missed when preparing the upload.
  
  tuxcmd-modules (0.6.70+ds-5.1) unstable; urgency=medium
  .
    * Non-maintainer upload.
    * Apply a patch by Vagrant Cascadian to ensure that tuxcmd-modules does not
      embed build paths in various binaries. (Closes: #1011500)
    * Apply a patch by Helmut Grohne to make it possible to cross-build
      tuxcmd-modules. (Closes: #941296)

The full debdiff is attached.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[tuxcmd-modules_0.6.70+ds-5.1_amd64.debdiff.txt (text/plain, attachment)]

Message #28 received at 1011500@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Chris Lamb <lamby@debian.org>, 1011500-quiet@bugs.debian.org, 1011500@bugs.debian.org, 1011500-submitter@bugs.debian.org, 941296@bugs.debian.org, 941296-submitter@bugs.debian.org

Subject: Re: Bug#1011500: tuxcmd-modules: reproducible-builds: embedded build paths in various binaries

Date: Tue, 22 Nov 2022 15:01:13 -0800

[Message part 1 (text/plain, inline)]

On 2022-11-18, Chris Lamb wrote:
> I've just uploaded an updated version of tuxcmd-modules 0.6.70+ds-5.1
> to DELAYED/3. This variant of the upload actually includes the fix for
> #941296 which was missed when preparing the upload.

This hasn't yet landed in the archive, was it actually uploaded to
DELAYED/3?

It could have been uploaded to DELAYED/0 (e.g. without delay) as a QA
upload rather than as an NMU...

>   tuxcmd-modules (0.6.70+ds-5.1) unstable; urgency=medium
>   .
>     * Non-maintainer upload.
>     * Apply a patch by Vagrant Cascadian to ensure that tuxcmd-modules does not
>       embed build paths in various binaries. (Closes: #1011500)
>     * Apply a patch by Helmut Grohne to make it possible to cross-build
>       tuxcmd-modules. (Closes: #941296)

live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 1011500@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Vagrant Cascadian" <vagrant@reproducible-builds.org>, 1011500-quiet@bugs.debian.org, 1011500@bugs.debian.org, 1011500-submitter@bugs.debian.org, 941296@bugs.debian.org, 941296-submitter@bugs.debian.org

Subject: Re: Bug#1011500: tuxcmd-modules: reproducible-builds: embedded build paths in various binaries

Date: Wed, 23 Nov 2022 06:35:15 +0000

Hi Vagrant,

> This hasn't yet landed in the archive, was it actually uploaded to
> DELAYED/3?

Somewhat unclear. I am pretty sure it was uploaded as I can find an
.upload file for it:

  $ cat tuxcmd-modules_0.6.70+ds-5.1_amd64.ssh-upload.upload
  Successfully uploaded tuxcmd-modules_0.6.70+ds-5.1.dsc to ssh.upload.debian.org for ssh-upload.
  Successfully uploaded tuxcmd-modules_0.6.70+ds.orig.tar.gz to ssh.upload.debian.org for ssh-upload.
  Successfully uploaded tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz to ssh.upload.debian.org for ssh-upload.
  Successfully uploaded tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb to ssh.upload.debian.org for ssh-upload.
  Successfully uploaded tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo to ssh.upload.debian.org for ssh-upload.
  Successfully uploaded tuxcmd-modules_0.6.70+ds-5.1_amd64.deb to ssh.upload.debian.org for ssh-upload.
  Successfully uploaded tuxcmd-modules_0.6.70+ds-5.1_amd64.changes to ssh.upload.debian.org for ssh-upload.

> It could have been uploaded to DELAYED/0 (e.g. without delay) as a QA
> upload rather than as an NMU...

Oh sure, but 3 days delay easily allows issues to be caught...

However, in lieu of working out what has happened here, I'll re-upload
now without any DELAYED value. Thanks. :)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #54 received at 1011500-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1011500-close@bugs.debian.org

Subject: Bug#1011500: fixed in tuxcmd-modules 0.6.70+ds-5.1

Date: Sun, 27 Nov 2022 18:22:13 +0000

Source: tuxcmd-modules
Source-Version: 0.6.70+ds-5.1
Done: Chris Lamb <lamby@debian.org>

We believe that the bug you reported is fixed in the latest version of
tuxcmd-modules, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1011500@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <lamby@debian.org> (supplier of updated tuxcmd-modules package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 17 Nov 2022 17:15:30 +0000
Source: tuxcmd-modules
Binary: tuxcmd-modules tuxcmd-modules-dbgsym
Architecture: source amd64
Version: 0.6.70+ds-5.1
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Chris Lamb <lamby@debian.org>
Description:
 tuxcmd-modules - VFS modules for tuxcmd file manager
Closes: 941296 1011500
Changes:
 tuxcmd-modules (0.6.70+ds-5.1) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Apply a patch by Vagrant Cascadian to ensure that tuxcmd-modules does not
     embed build paths in various binaries. (Closes: #1011500)
   * Apply a patch by Helmut Grohne to make it possible to cross-build
     tuxcmd-modules. (Closes: #941296)
Checksums-Sha1:
 6fc6ac3504be05519bc4b735f90243e135729577 1875 tuxcmd-modules_0.6.70+ds-5.1.dsc
 bd233e743db6949ad28e506161cb93d4af9d2af9 334896 tuxcmd-modules_0.6.70+ds.orig.tar.gz
 a264c655b39265b65c4065d58fab6572c96b0257 6868 tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz
 42dc661e2086ac54df0c42e5ffbd1b6ae7dbc4fa 1307420 tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb
 e4e4014005f9d087cd810769b5e32986a8f879ed 9119 tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo
 bfb94903a3657ed8b33ffe5ad0ae7737b1eb20a3 138300 tuxcmd-modules_0.6.70+ds-5.1_amd64.deb
Checksums-Sha256:
 96e8930d7de3491aac8ae313fe0899e955de9da168342e7f9a0f8474146aa29d 1875 tuxcmd-modules_0.6.70+ds-5.1.dsc
 2577a41c065b359fde332612432b069b95a107a9dde86ba7362b74c01fc5f907 334896 tuxcmd-modules_0.6.70+ds.orig.tar.gz
 d234e066ce887b420b25abf77d8049ccc3297ecde7f1f49c5625eb57f81a6783 6868 tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz
 2d5f5f09ec8e65f3b596833fe61a02663cd5cc5219b7fce50da7703860eadea5 1307420 tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb
 df12ddf7cb6e14f13e9b05d935411db7d0459d8f0e947b89a0b47468db147058 9119 tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo
 2692687ea478b023ece770fa70a1e351992e9fec72e66c8f6192187176c4861a 138300 tuxcmd-modules_0.6.70+ds-5.1_amd64.deb
Files:
 3c8e452d7fb0b5425894a5691f529ca0 1875 utils optional tuxcmd-modules_0.6.70+ds-5.1.dsc
 e62ee5fbf34fd29b7e5af2b303e3938b 334896 utils optional tuxcmd-modules_0.6.70+ds.orig.tar.gz
 fce9c00c254fd7d7f563dceacc40d4fa 6868 utils optional tuxcmd-modules_0.6.70+ds-5.1.debian.tar.xz
 3b3327be788e6252da55671fa7344905 1307420 debug optional tuxcmd-modules-dbgsym_0.6.70+ds-5.1_amd64.deb
 7b920c4425f943703b4367474ffc21fd 9119 utils optional tuxcmd-modules_0.6.70+ds-5.1_amd64.buildinfo
 7322b7342f4388b0b66ea75cc32ca8bf 138300 utils optional tuxcmd-modules_0.6.70+ds-5.1_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmN2bc8ACgkQHpU+J9Qx
Hli7MxAApPcmR/mNDPgbS/zFEaYK0QrBJopaehbvtr/Tv2xUPAEd6DQoN+RPSIou
lp/u8/x+AYSmOBkoPZwx5arN+rbowVIMocSrmgMtc3GzrAdDGVwNU1LbTfczT5BV
PAgTQnnt6WYmXza0rixRpWYH/e3McpEJXL+zyq/G/P6C9ACsURstwY5aKwhK4k8u
H1kCpeEylpzxq68s2rV7OZPPMyTPkbcQ3fStfTGBw2k/qtEQ/2ruRcgdn/r49bSb
KCut+YsZ+xLB2TbPxWOMl1tvlx+J17ShhOQJB5mbA5nlq+NqunCQWLqrSZFTk3P2
0JyA5ncIkyPf+crGKmfQSZp/icXgHDOTJgYgSTcu4BUKjUm283bZrg0b1egajgVA
4MLJRXK4ddWkbpLqYbrJLi5jt9AcPKF5H/8L3Tp6RHvutORgAob7bQ9jRDTiD9Pe
HXzI07lKAGir+VZuE65K129B+lmJvSpcfKEEltxdlE5hgOzeuCXVIXGItdN2LHOI
qpskOFrqENXnLJnJoJ6hcONr3JhTDk+qziNNdwaaD1VjASErGauriK98Y3uzdHok
ORjQ3s5TzzQVaoX/hjbSnKXqQW17umZpD9CJ81ECFkBvlgZ8zZ+sRxdhafwYCr6j
5TdgXEcN0sBunDEQb1jIVI6/yBD3iU3nzrRMU1MMx/sWssHFY38=
=n8IO
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.