Debian Bug report logs - #1010790
xgammon: reproducible-builds: embedded build paths in /usr/games/xgammon

version graph

Package: src:xgammon; Maintainer for src:xgammon is Debian QA Group <packages@qa.debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Tue, 10 May 2022 02:33:02 UTC

Severity: normal

Tags: patch

Fixed in version xgammon/0.99.1128-6

Done: Vagrant Cascadian <vagrant@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian QA Group <packages@qa.debian.org>:
Bug#1010790; Package src:xgammon. (Tue, 10 May 2022 02:33:04 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian QA Group <packages@qa.debian.org>. (Tue, 10 May 2022 02:33:04 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: xgammon: reproducible-builds: embedded build paths in /usr/games/xgammon
Date: Mon, 09 May 2022 19:31:40 -0700
[Message part 1 (text/plain, inline)]
Source: xgammon
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build path is embedded in /usr/games/xgammon:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/xgammon.html

  /build/1st/xgammon-0.99.1128/src/xgammon.c:286
  vs.
  /build/2/xgammon-0.99.1128/2nd/src/xgammon.c:286


The attached patch to debian/rules fixes this by passing CFLAGS to make.

Alternately, updating the packaging to use dh/debhelper at a recent
compat level would also likely fix this.


With this patch applied, xgammon should build reproducibly on
tests.reproducible-builds.org!


live well,
  vagrant
[0001-debian-rules-Pass-CFLAGS-to-make.patch (text/x-diff, inline)]
From 60b8556299e2e12bbebbe38e463757f2635a72b8 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 10 May 2022 02:27:23 +0000
Subject: [PATCH] debian/rules: Pass CFLAGS to make.

---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 3ea1ac6..f63f8c8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,7 +9,7 @@ build: build-stamp
 build-stamp:
 	dh_testdir
 	cd src && imake -I/usr/lib/X11/config
-	cd src && $(MAKE) 
+	cd src && $(MAKE) CFLAGS="$(CFLAGS)"
 	touch build-stamp
 
 clean:
-- 
2.36.0

[signature.asc (application/pgp-signature, inline)]

Reply sent to Vagrant Cascadian <vagrant@debian.org>:
You have taken responsibility. (Tue, 10 May 2022 03:51:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Tue, 10 May 2022 03:51:03 GMT) (full text, mbox, link).


Message #10 received at 1010790-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1010790-close@bugs.debian.org
Subject: Bug#1010790: fixed in xgammon 0.99.1128-6
Date: Tue, 10 May 2022 03:49:07 +0000
Source: xgammon
Source-Version: 0.99.1128-6
Done: Vagrant Cascadian <vagrant@debian.org>

We believe that the bug you reported is fixed in the latest version of
xgammon, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010790@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Vagrant Cascadian <vagrant@debian.org> (supplier of updated xgammon package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 09 May 2022 20:28:00 -0700
Source: xgammon
Architecture: source
Version: 0.99.1128-6
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: Vagrant Cascadian <vagrant@debian.org>
Closes: 999316 1010790
Changes:
 xgammon (0.99.1128-6) unstable; urgency=medium
 .
   * QA upload.
   * debian/rules: Pass CFLAGS to make. (Closes: #1010790)
   * debian/rules: Switch to dh. (Closes: #999316)
   * Set Rules-Requires-Root to "no".
Checksums-Sha1:
 dacd6ed0d25c8c0eab186d5f6f0350a3c2d270e9 1269 xgammon_0.99.1128-6.dsc
 4ede4d2d2ddaa61c5bdd8e053a082d479f4cf334 7532 xgammon_0.99.1128-6.debian.tar.xz
Checksums-Sha256:
 c2bf3f125a5f2e3d5fc53b67c0a797b831cf949773824c1d52459ceb97b0ea43 1269 xgammon_0.99.1128-6.dsc
 5a38fef994014e16fd6c78fa83d226c4cb29359af06c11a58a497506351eb6c9 7532 xgammon_0.99.1128-6.debian.tar.xz
Files:
 04b769d20bbd36817ecf2063243a8057 1269 games optional xgammon_0.99.1128-6.dsc
 fb9dd4bb13d861a1658c2acc9dd495eb 7532 games optional xgammon_0.99.1128-6.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iIkEARYKADEWIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYnndWBMcdmFncmFudEBk
ZWJpYW4ub3JnAAoJENxRj8h/lxaqDzYBAOe7zLAZaYGUWFNTKy4fXeGu0xKQ5mLC
spnCTbXCdkR7AP0RJ+8NSs/PmBx+jYCKujEtmrOrBZrj1w5FTsegDawODA==
=ekEN
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Fri, 17 Jun 2022 07:27:19 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 12:39:14 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.