Debian Bug report logs - #1010463
fceux: reproducible builds: Timestamps embedded in /usr/games/fceux

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: fceux: reproducible builds: Timestamps embedded in /usr/games/fceux

Date: Sun, 01 May 2022 20:10:59 -0700

[Message part 1 (text/plain, inline)]

Source: fceux
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build timestamp is embedded in /usr/games/fceux:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/fceux.html

  2021-11-21·13:43:00
  vs.
  2021-11-22·15:43:00

There is a already patch which adds support for SOURCE_DATE_EPOCH, but
the timestamps still vary dependent on timezone. The attached patch
updates the SOURCE_DATE_EPOCH patch to use the UTC timezone in the cmake
TIMESTAMP call.

With this patch applied, fceux should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining fceux!


live well,
  vagrant

[0001-debian-patches-Update-SOURCE_DATE_EPOCH-patch-to-spe.patch (text/x-diff, inline)]

From c6b223023940277a269eed92763d5a163dd09aba Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 2 May 2022 02:59:02 +0000
Subject: [PATCH] debian/patches: Update SOURCE_DATE_EPOCH patch to specify UTC
 timezone.

The cmake TIMESTAMP function defaults to the local timezone.

https://tests.reproducible-builds.org/debian/issues/unstable/timestamps_in_cmake_issue.html
---
 debian/patches/support_SOURCE_DATE_EPOCH.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/patches/support_SOURCE_DATE_EPOCH.patch b/debian/patches/support_SOURCE_DATE_EPOCH.patch
index ee6e494..35a2939 100644
--- a/debian/patches/support_SOURCE_DATE_EPOCH.patch
+++ b/debian/patches/support_SOURCE_DATE_EPOCH.patch
@@ -8,7 +8,7 @@
 +# the FCEUX_BUILD_TIMESTAMP preprocessor definition.
 +# Note: with CMake >= 3.8.0, this will respect SOURCE_DATE_EPOCH. For more info,
 +#       see <https://reproducible-builds.org/docs/source-date-epoch/>.
-+string(TIMESTAMP BUILD_TS "%Y-%m-%d %H:%M:%S")
++string(TIMESTAMP BUILD_TS "%Y-%m-%d %H:%M:%S" UTC)
 +add_definitions( -DFCEUX_BUILD_TIMESTAMP=\"${BUILD_TS}\" )
 +
  if (WIN32)
-- 
2.36.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 1010463-submitter@bugs.debian.org (full text, mbox, reply):

From: Joseph Nahmias <noreply@salsa.debian.org>

To: 1010463-submitter@bugs.debian.org

Subject: Bug#1010463 marked as pending in fceux

Date: Wed, 18 May 2022 04:20:10 +0000

Control: tag -1 pending

Hello,

Bug #1010463 in fceux reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/games-team/fceux/-/commit/6896afb1c7772e37181b18a432d282f589824965

------------------------------------------------------------------------
use UTC for calculating SOURCE_DATE_EPOCH

Thanks: Vagrant Cascadian <vagrant@reproducible-builds.org>
Closes: #1010463
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1010463

Message #15 received at 1010463-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1010463-close@bugs.debian.org

Subject: Bug#1010463: fixed in fceux 2.6.4+dfsg1-1

Date: Thu, 19 May 2022 04:18:44 +0000

Source: fceux
Source-Version: 2.6.4+dfsg1-1
Done: Joseph Nahmias <jello@debian.org>

We believe that the bug you reported is fixed in the latest version of
fceux, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1010463@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joseph Nahmias <jello@debian.org> (supplier of updated fceux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 18 May 2022 23:15:22 -0400
Source: fceux
Architecture: source
Version: 2.6.4+dfsg1-1
Distribution: unstable
Urgency: medium
Maintainer: Joseph Nahmias <jello@debian.org>
Changed-By: Joseph Nahmias <jello@debian.org>
Closes: 1010463
Changes:
 fceux (2.6.4+dfsg1-1) unstable; urgency=medium
 .
   * [67bd672] drop out of date sf.net source location
   * [03d43eb] New upstream version 2.6.4+dfsg1
   * [8c69163] add copyright info for new source files
   * [0a3d31c] update upstream git hash
   * [87d4ae8] drop patch merged upstream
   * [1300dab] refresh patches
   * [6896afb] use UTC for calculating SOURCE_DATE_EPOCH.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>
     (Closes: #1010463)
   * [fb8a17f] standardize Vcs field spellings
   * [6046861] work around weird interaction between faketime and quilt patch
     this should make the build reproducible in salsa-ci.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>
Checksums-Sha1:
 6ee7a4217b425e13a0f32f5616b8909922c75420 1977 fceux_2.6.4+dfsg1-1.dsc
 8091f7808e093455d83f61445c217a8a9e1140aa 2260716 fceux_2.6.4+dfsg1.orig.tar.xz
 16cfaa1c996d419a63d73c35f3e70a0356823037 10212 fceux_2.6.4+dfsg1-1.debian.tar.xz
 2930e626d6ed7a0427021a339f8375792aff1775 13367 fceux_2.6.4+dfsg1-1_amd64.buildinfo
Checksums-Sha256:
 ad6d2dc4bdc9c891f3889eef5b0c6b0cdd9b2592ef354041a83ba9b0c7b8be39 1977 fceux_2.6.4+dfsg1-1.dsc
 e764f9c29de1723ab2a47d358fee6125e6c082786e5c29e245a969a19b4fb73a 2260716 fceux_2.6.4+dfsg1.orig.tar.xz
 45ac309b86e4e6a437549d5e2b42e51905ae08b62f6b2e2cd3fe71469828f630 10212 fceux_2.6.4+dfsg1-1.debian.tar.xz
 23229917d7c7e1a1bb3a41490edadb10444c85d15f71f4883ffc7c5584804ebd 13367 fceux_2.6.4+dfsg1-1_amd64.buildinfo
Files:
 44e26727d42ed7f4495ed36dce85e7b3 1977 games optional fceux_2.6.4+dfsg1-1.dsc
 271c5747ef11f6734cdbeb52cf1bcf6b 2260716 games optional fceux_2.6.4+dfsg1.orig.tar.xz
 d31fdbe0497b944fc79595ea3bafc2f0 10212 games optional fceux_2.6.4+dfsg1-1.debian.tar.xz
 6bcffd43d6e1ac9a0ddb2cd1305f4611 13367 games optional fceux_2.6.4+dfsg1-1_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEcxc7CTsDz7hRCK0UsRvZGQeaO5gFAmKFwH0ACgkQsRvZGQea
O5hASRAAk8fzRNwDizfUB7CDV/wti2IQa130U49Dg++7hGb/1CJN9wwx6nkuUt7b
JrAgrafzgr40NZhaq8DDqiHz0RyyTQZwX8juKw8fO8paw+z8MeMTnKiSlBqN9Lhy
/lbslolZEipQ+wsMlft0GT59IHM7idh3lM590thodiLJ0uDnZUcYtHV8oB450TQh
ZF3Az/owM48y/P/txIqYwuaD1SkNLs4CbAxqCYFJGZDoEXX5mHwyOboW3q0yTJEV
oXpIdRvM1PevYgcjKMzjcjErZxMLJFfrukxx7kx5TdSgZks/8Rf+nWpDzPoN+k2W
/nWIHuaNlGjfm0uBc7J3tnWp/e0kIB+Nm7sJiXzUU35Thr3s8iTeZOEFNYkHZa2u
KcPxgCPK+aoPg9LgLaNcBUWq7/9Zzd2MUO9R4iT7DFx4uurJd01GhXiDK/qIzLoM
idezR8NLZo9baZz4rEG/saJudb+6KnPjOkYulD3XoLjO3re/Ia1hP5GvS2KLvZLe
j/T5RF2dzWq2XEnINr14HHQL0OtnG8h1PuwJk9qX7zzqS3R9tSPq0AxCXfSNu1Ga
J/PI+CHtmkbTAx9WNrzMcZLnwE+NzrbsRKS59OuXGhoiaQQVDVaG14HzixBLNNJ2
lv20jlIgkAuoI5affuM0BOO8e7o6mdhkeJ4vcsmxafTFbSv8hnE=
=12Bh
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.