Debian Bug report logs - #1009799
puppet: reproducible builds: domain name embedded in puppet.conf.5 man page

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: puppet: reproducible builds: domain name embedded in puppet.conf.5 man page

Date: Sun, 17 Apr 2022 19:58:46 -0700

[Message part 1 (text/plain, inline)]

Source: puppet
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: hostname
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The domainname of the system is embeded in the puppet.conf.5 man page:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/puppet.html

  \fIDefault\fR:·debian\.net
vs.
  \fIDefault\fR:

The attached patch is an update to the previous reproducible builds
patch, fixing a new occurance of the domain name. It checks if
SOURCE_DATE_EPOCH is set, and displays a fixed string instead of the
running system's domain name.


This patch appears to apply to puppet from experimental too, although I
was unable to get that to build to confirm the fix.


With this patch applied, puppet should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining puppet!


live well,
  vagrant

[0001-lib-puppet-defaults.rb-Patch-srv_domain-to-generate-.patch (text/x-diff, inline)]

From f2fbbd0b92ac3fdd5647c59802680da91814d91c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Mon, 18 Apr 2022 02:47:05 +0000
Subject: [PATCH] lib/puppet/defaults.rb: Patch "srv_domain" to generate
 puppet.conf.5 manpage reproducibly.

Similar to how this was handled with "certname", when
SOURCE_DATE_EPOCH is set, print a descriptive string rather than the
system's domain name.
---
 lib/puppet/defaults.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb
index 404c02e939..96e6d6fdf6 100644
--- a/lib/puppet/defaults.rb
+++ b/lib/puppet/defaults.rb
@@ -1587,7 +1587,7 @@ EOT
       :desc       => "Whether the server will search for SRV records in DNS for the current domain.",
     },
     :srv_domain => {
-      :default    => lambda { Puppet::Settings.domain_fact },
+      :default    => lambda { ENV.has_key?('SOURCE_DATE_EPOCH') ? '(node\'s fully qualified domain name)' : Puppet::Settings.domain_fact },
       :desc       => "The domain which will be queried to find the SRV records of servers to use.",
     },
     :ignoreschedules => {
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1009799@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <chris@reproducible-builds.org>

To: 1009799@bugs.debian.org

Subject: Re: Bug#1009799: puppet: reproducible builds: domain name embedded in puppet.conf.5 man page

Date: Mon, 03 Oct 2022 07:55:02 -0700

Vagrant Cascadian wrote:

> This patch appears to apply to puppet from experimental too, although I
> was unable to get that to build to confirm the fix.

See also bug #1021198, which is a parallel bug in the "puppet-agent"
source package.


Regards,

-- 
      o
    ⬋   ⬊      Chris Lamb
   o     o     reproducible-builds.org 💠
    ⬊   ⬋
      o

Message #15 received at 1009799-done@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 610877-done@bugs.debian.org,670337-done@bugs.debian.org,693203-done@bugs.debian.org,723188-done@bugs.debian.org,809786-done@bugs.debian.org,869183-done@bugs.debian.org,879230-done@bugs.debian.org,894800-done@bugs.debian.org,927801-done@bugs.debian.org,928463-done@bugs.debian.org,950182-done@bugs.debian.org,950185-done@bugs.debian.org,983913-done@bugs.debian.org,984603-done@bugs.debian.org,987254-done@bugs.debian.org,987255-done@bugs.debian.org,989224-done@bugs.debian.org,1003867-done@bugs.debian.org,1006231-done@bugs.debian.org,1009643-done@bugs.debian.org,1009799-done@bugs.debian.org,1014772-done@bugs.debian.org,

Cc: puppet@packages.debian.org

Subject: Bug#1021202: Removed package(s) from unstable

Date: Tue, 04 Oct 2022 17:23:44 +0000

Version: 5.5.22-4+rm

Dear submitter,

as the package puppet has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see https://bugs.debian.org/1021202

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

Please note that the changes have been done on the master archive and
will not propagate to any mirrors until the next dinstall run at the
earliest.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
ftpmaster@ftp-master.debian.org.

Debian distribution maintenance software
pp.
Thorsten Alteholz (the ftpmaster behind the curtain)

Send a report that this bug log contains spam.