Debian Bug report logs - #1008708
pysolfc: After installing python3.10, pysolfc cannot start

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Roger D. Cook" <roger@rogerdcook.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: pysolfc: After installing python3.10, pysolfc cannot start

Date: Wed, 30 Mar 2022 16:29:14 -0500

Package: pysolfc
Version: 2.6.4-3
Severity: grave
Tags: newcomer
Justification: renders package unusable

Dear Maintainer,

1. Attempted to start pysolfc through the menus; it failed to start.
2. Attempted to start from the command line; it failed to start with
   the following messaging:

$ pysolfc
Traceback (most recent call last):
  File "/usr/games/pysolfc", line 36, in <module>
    from pysollib.main import main  # noqa: E402,I202
  File "/usr/share/games/pysolfc/pysollib/main.py", line 30, in <module>
    from pysollib.app import Application
  File "/usr/share/games/pysolfc/pysollib/app.py", line 32, in <module>
    from pysollib.images import Images, SubsampledImages
  File "/usr/share/games/pysolfc/pysollib/images.py", line 28, in <module>
    from pysollib.pysoltk import copyImage, createBottom, createImage, loadImage
  File "/usr/share/games/pysolfc/pysollib/pysoltk.py", line 35, in <module>
    from pysollib.tile.tkhtml import *  # noqa: F401,F403
  File "/usr/share/games/pysolfc/pysollib/tile/tkhtml.py", line 29, in <module>
    from pysollib.ui.tktile.tkhtml import Base_HTMLViewer
  File "/usr/share/games/pysolfc/pysollib/ui/tktile/tkhtml.py", line 24, in <module>
    import formatter
ModuleNotFoundError: No module named 'formatter'
$

Expected result is that the game starts.

After researching, I came across https://github.com/shlomif/PySolFC/issues/217
and https://github.com/shlomif/PySolFC/pull/218, which:
a) explained that the formatter module was deprecated in Python 3.4 and
   removed in 3.10, and
b) fixed the issue upstream in PySolFC version 2.14, released September 9,
   2021.

I believe the best fix is to import the newest version of pysolfc to the
Debian ecosystem.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.16.0-5-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages pysolfc depends on:
ii  python3            3.10.4-1
ii  python3-configobj  5.0.6-5
ii  python3-pygame     2.1.2+dfsg-3
ii  python3-random2    1.0.1-2.1
ii  python3-six        1.16.0-3
ii  python3-tk         3.9.12-1

Versions of packages pysolfc recommends:
ii  python3-pil.imagetk  9.0.1-1

Versions of packages pysolfc suggests:
ii  freecell-solver-bin  5.0.0-2+b1
ii  pysolfc-cardsets     2.0+dfsg2-2.1

-- no debconf information

Message #12 received at 1008708@bugs.debian.org (full text, mbox, reply):

From: Heinz Repp <Heinz.Repp@online.de>

To: 1008708@bugs.debian.org

Subject: Bug is fixed in 2.14, current is 2.15

Date: Thu, 21 Apr 2022 17:36:46 +0200

Unfortunately PysolFC is severely outdated in Debian. PysolFC not 
running with Python 3.10 has been fixed in 2.14, the current version is 
2.15. The Debian package hasn't seen updates since two years ago, and 
now it's broken. Please update to 2.15 a.s.a.p.!

Message #21 received at 1008708@bugs.debian.org (full text, mbox, reply):

From: Athos Ribeiro <athos.ribeiro@canonical.com>

To: 1008708@bugs.debian.org

Subject: Regarding pysolfc embedding a python module

Date: Tue, 6 Sep 2022 10:10:30 -0300

Hi,

First of all, IANAL.

As I commented in a similar bug in Ubuntu [1], while the fix for this
issue is available upstream and seems technically straightforward, it
injects a deprecated python module in its code base and re-licenses it
as CC0. The PSF license suggests "that PSF's License Agreement and PSF's
notice of copyright [...] are retained in Python alone or in any
derivative version" and that "in the event Licensee prepares a
derivative work that is based on or incorporates Python or any part
thereof [...], then Licensee hereby agrees to include in any such work a
brief summary of the changes made to Python."

[1] https://bugs.launchpad.net/ubuntu/+source/pysolfc/+bug/1967793/comments/8


-- 
Athos Ribeiro

Message #28 received at 1008708@bugs.debian.org (full text, mbox, reply):

From: Bastian Germann <bage@debian.org>

To: 1008708@bugs.debian.org

Subject: Re: Regarding pysolfc embedding a python module

Date: Tue, 19 Sep 2023 20:27:07 +0200

On Tue, 6 Sep 2022 10:10:30 -0300 Athos Ribeiro wrote:
> As I commented in a similar bug in Ubuntu [1], while the fix for this
> issue is available upstream and seems technically straightforward, it
> injects a deprecated python module in its code base and re-licenses it
> as CC0.
Only the changes to the file are licensed under CC0, which is clarified by
https://github.com/shlomif/PySolFC/commit/f0fb0500ddc35bd34ec6f0ee136342e32f0a3403

Message #39 received at 1008708-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1008708-close@bugs.debian.org

Subject: Bug#1008708: fixed in pysolfc 3.0.0-1

Date: Tue, 30 Jul 2024 21:22:29 +0000

[Message part 1 (text/plain, inline)]

Source: pysolfc
Source-Version: 3.0.0-1
Done: Alexandre Detiste <tchet@debian.org>

We believe that the bug you reported is fixed in the latest version of
pysolfc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1008708@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexandre Detiste <tchet@debian.org> (supplier of updated pysolfc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 30 Jul 2024 22:48:22 +0200
Source: pysolfc
Architecture: source
Version: 3.0.0-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Alexandre Detiste <tchet@debian.org>
Closes: 1008708 1050280
Changes:
 pysolfc (3.0.0-1) unstable; urgency=medium
 .
   * Team Upload
   * New upstream version 3.0.0 (Closes: #1008708)
   * Refresh patch
   * Simply use pytest for testing
 .
   [ Bastian Germann ]
   * Remove retired Uploader (Closes: #1050280)
Checksums-Sha1:
 e3c81422e64162f45624d2497eb5032fb4d1fc03 2477 pysolfc_3.0.0-1.dsc
 026409171aa9f852eeb8b3e585807ed5b9ab427c 25188212 pysolfc_3.0.0.orig-cardsets.tar.xz
 ccff6dcf75bcb09d5787fc07bf25b40445f82e41 33364860 pysolfc_3.0.0.orig.tar.xz
 74a5468ce671c111b1ee98601cd0328717881f29 7676 pysolfc_3.0.0-1.debian.tar.xz
 df28fb480d7203c685b808641382bc81ede2d257 10180 pysolfc_3.0.0-1_source.buildinfo
Checksums-Sha256:
 20ccb99e7505ae0f760de4bc75de018a5ecaffffaa14f21848027820268c3c89 2477 pysolfc_3.0.0-1.dsc
 faf70f5d1955cc46f2e840f7600df2933b06890fdc874b0bf5da446d1fab288b 25188212 pysolfc_3.0.0.orig-cardsets.tar.xz
 5047ca10e8d5d635a0fbf7387c71b6c5e090e51a3ad2ab8a1bad649c0c3c9a17 33364860 pysolfc_3.0.0.orig.tar.xz
 f278cad3724bff4f0ad079a041f1ffac0f23a5c48fb293293dd8048a3d518103 7676 pysolfc_3.0.0-1.debian.tar.xz
 8b799ffc526b5d2baabf27c1eecd435faaf6f70f43b9f3db8f5211d07c0c232e 10180 pysolfc_3.0.0-1_source.buildinfo
Files:
 9a6bbe4c7368f1125a879731f6b697ab 2477 games optional pysolfc_3.0.0-1.dsc
 0bdd0de61bfe5a97ad9eb10516f7356a 25188212 games optional pysolfc_3.0.0.orig-cardsets.tar.xz
 082aa2ea9d84da694170d8b69135a872 33364860 games optional pysolfc_3.0.0.orig.tar.xz
 b40fe610d2663b1df65fad3f8dcaeacb 7676 games optional pysolfc_3.0.0-1.debian.tar.xz
 102bd03e4f715dd0f8485cd19b75b73c 10180 games optional pysolfc_3.0.0-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEj23hBDd/OxHnQXSHMfMURUShdBoFAmapUpcRHHRjaGV0QGRl
Ymlhbi5vcmcACgkQMfMURUShdBrZeA/6A4UNLU9HAi/R/+Y4xErd3wtdb/U8YNVZ
oJJo8UqpfnobOdb1V7rdFxA56/xRW3n3EahW/1BsqF9wmHAzkM93IJ4L1uLJEwAk
acRLPZz7aOCdRW/QcK4T1CIHOiA6YpUXcKomsDySZowcUZlib/LBtOxYtn8Sp3ct
Ot9Np9+bdyAiincsSkPqiVmqtpqNlFTna3NrH5HezpZCgCQGJiqwKMAB3fcvZw8O
PbXD6cWSkcHpsTVnneSPMRdzxzVF4fI4Jyx62nb6vgqp2x0tP1u9LHJOIvzdekXd
PA2dH/fNaCbbItpU0uhnL5hq8Cf0aHmMaWl8jBqpKgKpANnO15kGy4OCL8VzGgxe
z6OOxiQRLmwTd3nvwZv2J8PXhHTae8XyiNNlOWxUwHQj4oIZqwaJLmhU3nlfcjpE
7S62OmtUNVAoykQab0JHYWIlJZhjP6YdXOM3SzhW553NnqcRJMq/3czA1G3DuI2z
VVfL1qL31/XrWWwYz4BAT5P9idVtJvpJwGsL5YhOB726T1xBmnmACdLUEi71H5XR
xguB/VlkuqDsZ1RBVko7tue+dVkR186Olk/DiNLtqqidqHB5TRCBks31fqVq7t4V
a4nmCV5ac81H2X9cAvvTD+a6IXrJ+3r1ObxyMRAocWL/6u14Uf4/h6PSgPT3oU/I
vrC25rZKxPQ=
=9R6r
-----END PGP SIGNATURE-----

[Message part 2 (application/pgp-signature, inline)]

Send a report that this bug log contains spam.