Debian Bug report logs - #1007185
btrfsmaintenance: reproducible builds: Timestamp embedded in manpage

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: btrfsmaintenance: reproducible builds: Timestamp embedded in manpage

Date: Sat, 12 Mar 2022 14:44:57 -0800

[Message part 1 (text/plain, inline)]

Source: btrfsmaintenance
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps locale
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build timestamp is embedded in
/usr/share/man/man8/btrfsmaintenance.8.gz:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/arm64/diffoscope-results/btrfsmaintenance.html

  .TH·BTRFSMAINTENANCE·8·"12·March,·2022"·v0.5
  vs.
  .TH·BTRFSMAINTENANCE·8·"13·March,·2022"·v0.5

The attached patch fixes this by passing the --utc argument to date in
debian/create-man-page.sh and by using a locale-independent date format.


With this patch applied, btrfsmaintenance should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining btrfsmaintenance!


live well,
  vagrant

[0001-debian-create-man-page.sh-Use-UTC-timezone-and-a-loc.patch (text/x-diff, inline)]

From b7b79e3fa70b925e173e4c21aa6022a6a0a5987e Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 12 Mar 2022 22:37:04 +0000
Subject: [PATCH] debian/create-man-page.sh: Use UTC timezone and a
 locale-idependent date string.

Without this, the locale may output a translated month, or building in
a different timezone may result in a different day or month.
---
 debian/create-man-page.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/create-man-page.sh b/debian/create-man-page.sh
index 9057e4d..5d8fa39 100755
--- a/debian/create-man-page.sh
+++ b/debian/create-man-page.sh
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-man_date=$(date -d "@$(dpkg-parsechangelog -STimestamp)" +"%d %B, %Y")
+man_date=$(date --utc -d "@$(dpkg-parsechangelog -STimestamp)" +"%Y-%m-%d")
 
 cat << EOF > debian/tmp/btrfsmaintenance.md
 % BTRFSMAINTENANCE 8 "$man_date" v$DEB_VERSION_UPSTREAM
-- 
2.35.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1007185@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <sten@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 1007185@bugs.debian.org

Subject: Re: Bug#1007185: btrfsmaintenance: reproducible builds: Timestamp embedded in manpage

Date: Sat, 12 Mar 2022 18:42:23 -0500

[Message part 1 (text/plain, inline)]

Hi Vagrant!

Vagrant Cascadian <vagrant@reproducible-builds.org> writes:

> Source: btrfsmaintenance
> Severity: normal
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: timestamps locale
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
>
> The build timestamp is embedded in
> /usr/share/man/man8/btrfsmaintenance.8.gz:
>
>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/arm64/diffoscope-results/btrfsmaintenance.html
>
>   .TH·BTRFSMAINTENANCE·8·"12·March,·2022"·v0.5
>   vs.
>   .TH·BTRFSMAINTENANCE·8·"13·March,·2022"·v0.5
>
> The attached patch fixes this by passing the --utc argument to date in
> debian/create-man-page.sh and by using a locale-independent date format.
>
>
> With this patch applied, btrfsmaintenance should build reproducibly on
> tests.reproducible-builds.org!
>

Wow!  Thank you for catching this so quickly, and for submitting a
patch, and sorry I missed this.  By the way, are ISO 8601 dates in man
pages a goal in Debian?  I noted GNU man pages use "%B %d, %Y", and
chose the more international little endian long-form.  There's no
problem changing to ISO 8601 as you suggest, I'm just curious.

>
> Thanks for maintaining btrfsmaintenance!

You're welcome :-)

On a tangential topic, what would you recommend for making shell scripts
such as btrfsmaintenance aware of plug/unplug (alternatively off battery
vs on battery) state, to suspend and resume CPU and IO intensive
operations, and without falling back to polling?  UPower, to cover both
laptops and servers that have a UPS?

Cheers,
Nicholas

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 1007185@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Nicholas D Steeves <sten@debian.org>, 1007185@bugs.debian.org

Subject: Re: Bug#1007185: btrfsmaintenance: reproducible builds: Timestamp embedded in manpage

Date: Sun, 13 Mar 2022 14:00:44 -0700

[Message part 1 (text/plain, inline)]

On 2022-03-12, Nicholas D. Steeves wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> writes:
>> The build timestamp is embedded in
>> /usr/share/man/man8/btrfsmaintenance.8.gz:
>>
>>   https://tests.reproducible-builds.org/debian/rb-pkg/unstable/arm64/diffoscope-results/btrfsmaintenance.html
>>
>>   .TH·BTRFSMAINTENANCE·8·"12·March,·2022"·v0.5
>>   vs.
>>   .TH·BTRFSMAINTENANCE·8·"13·March,·2022"·v0.5
>>
>> The attached patch fixes this by passing the --utc argument to date in
>> debian/create-man-page.sh and by using a locale-independent date format.
>>
>>
>> With this patch applied, btrfsmaintenance should build reproducibly on
>> tests.reproducible-builds.org!

> Wow!  Thank you for catching this so quickly, and for submitting a
> patch, and sorry I missed this.

Just happened to look at it shortly after you had apparently
uploaded. heh. :)


> By the way, are ISO 8601 dates in man pages a goal in Debian?

I'm not aware of any goal, it just seems like the most consistent format
to use, works well for reproducible builds, and isn't "wrong". :)


> I noted GNU man pages use "%B %d, %Y", and
> chose the more international little endian long-form.  There's no
> problem changing to ISO 8601 as you suggest, I'm just curious.

Maybe it'd be worth exploring getting GNU to move towards ISO 8601
instead... I'll plant that seed in the back of my mind and see where it
goes!


>> Thanks for maintaining btrfsmaintenance!
>
> You're welcome :-)
>
> On a tangential topic, what would you recommend for making shell scripts
> such as btrfsmaintenance aware of plug/unplug (alternatively off battery
> vs on battery) state, to suspend and resume CPU and IO intensive
> operations, and without falling back to polling?  UPower, to cover both
> laptops and servers that have a UPS?

No opinions on that, good luck!


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 1007185@bugs.debian.org (full text, mbox, reply):

From: Nicholas D Steeves <sten@debian.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 1007185@bugs.debian.org

Subject: Re: Bug#1007185: btrfsmaintenance: reproducible builds: Timestamp embedded in manpage

Date: Sun, 13 Mar 2022 20:08:10 -0400

[Message part 1 (text/plain, inline)]

Vagrant Cascadian <vagrant@reproducible-builds.org> writes:

> On 2022-03-12, Nicholas D. Steeves wrote:
>> Vagrant Cascadian <vagrant@reproducible-builds.org> writes:
>
>> Wow!  Thank you for catching this so quickly, and for submitting a
>> patch, and sorry I missed this.
>
> Just happened to look at it shortly after you had apparently
> uploaded. heh. :)
>

Haha!

>> By the way, are ISO 8601 dates in man pages a goal in Debian?
>
> I'm not aware of any goal, it just seems like the most consistent format
> to use, works well for reproducible builds, and isn't "wrong". :)
>

ACK, applied, and uploaded.

>> I noted GNU man pages use "%B %d, %Y", and
>> chose the more international little endian long-form.  There's no
>> problem changing to ISO 8601 as you suggest, I'm just curious.
>
> Maybe it'd be worth exploring getting GNU to move towards ISO 8601
> instead... I'll plant that seed in the back of my mind and see where it
> goes!
>

Cool, feel free to CC me if you go through with it, I'm curious how the
conversation will go

>> On a tangential topic, what would you recommend for making shell scripts
>> such as btrfsmaintenance aware of plug/unplug (alternatively off battery
>> vs on battery) state, to suspend and resume CPU and IO intensive
>> operations, and without falling back to polling?  UPower, to cover both
>> laptops and servers that have a UPS?
>
> No opinions on that, good luck!
>

Thanks!  I hope there won't be many tricky blockers or pitfalls when I
finally get around to it (users seem to want to want it, but my backlog
is still huge).

Cheers,
Nicholas

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 1007185-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1007185-close@bugs.debian.org

Subject: Bug#1007185: fixed in btrfsmaintenance 0.5-3

Date: Mon, 14 Mar 2022 00:19:25 +0000

Source: btrfsmaintenance
Source-Version: 0.5-3
Done: Nicholas D Steeves <sten@debian.org>

We believe that the bug you reported is fixed in the latest version of
btrfsmaintenance, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1007185@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nicholas D Steeves <sten@debian.org> (supplier of updated btrfsmaintenance package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 13 Mar 2022 20:00:44 -0400
Source: btrfsmaintenance
Architecture: source
Version: 0.5-3
Distribution: unstable
Urgency: medium
Maintainer: Nicholas D Steeves <sten@debian.org>
Changed-By: Nicholas D Steeves <sten@debian.org>
Closes: 1007185
Changes:
 btrfsmaintenance (0.5-3) unstable; urgency=medium
 .
   [ Vagrant Cascadian ]
   * debian/create-man-page.sh: Use UTC timezone and a locale-idependent date
     string.  Without this, the locale may output a translated month, or
     building in a different timezone may result in a different day or month.
     (Closes: #1007185)
Checksums-Sha1:
 0aa7641b70bb08f365d1d3713ee214e2fa2419d8 1941 btrfsmaintenance_0.5-3.dsc
 786241e64618bb32dd5eb2f771b310a73e601f62 9668 btrfsmaintenance_0.5-3.debian.tar.xz
 aefa322e4c55c2163adfedb648c8ed1d594c9ebc 5924 btrfsmaintenance_0.5-3_amd64.buildinfo
Checksums-Sha256:
 a06003b3e1e0883fcf88ab3f1e85c3232f564ab671f6d6fdc27dd7dab67e4702 1941 btrfsmaintenance_0.5-3.dsc
 5b18adc35be0fd32232d331f2bc48de6b4ddb466179d511b4ec8c072bf79e9cb 9668 btrfsmaintenance_0.5-3.debian.tar.xz
 0854aece2e0119b5d03776a0f07e1418873a6ae3769c76413163cd5c79ed9d1a 5924 btrfsmaintenance_0.5-3_amd64.buildinfo
Files:
 1cf717ebfd36f5cfcd22148b9efee56e 1941 admin optional btrfsmaintenance_0.5-3.dsc
 649e9c44b05b91841aa7aa9f8b1388bd 9668 admin optional btrfsmaintenance_0.5-3.debian.tar.xz
 e4d6f2b8587c0afe9a585f0c8cff6b88 5924 admin optional btrfsmaintenance_0.5-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmIuhoQACgkQWogwR199
EGFHzRAAuvx7ukVFrUNbog8wbAX0TFJqOBWCvRZTLojIfha7/2rY2SQ76h/tx8DF
G+RAh01ihJiAFY24/qnam3Yj+a4fJb3CXIjiUGIKUtbZnN3/ncT6sdsa5ebrCbST
2MtV0DZbbxw5OTZDv9nD7Hb8IfVV87nb9aFMPaj5QKl9RhwyEpWTvtq6aXvZoiWl
NFe6HVegRQIMra5MAMMk9/tDtClGNKu1skwL5KlKz99zAZ4IVOQzD7ULljKpvQ2S
cSJdaG9pv7eixJcUWhelcJhjcH+jr3v8aZjUpQqduC2q2O+SG6W83vy94tSS2kh1
KUvLuhSBWsllO9UF+cxzwmTB2srD/KUoQdfkqajrJZZUGRds2JeXM87b+/XAbtfv
IzV1uZB8UYRrT4XX1wOP5/yfiUfQqlKoWbxeCkz/ioastqJ0V82AJx3cqgPg4GJu
kh3mdyDyS6bT67/+8rDXTsukOG410sEPjvAhw2VC9BoyH9mVUm0CyXMk3+c8zQP2
Tp5nIz619klREr80J/yfmuce9PMSGAE71KiX/Zeg0P9CmLi3eDLNL1MLAph1MHvq
GrfqjcVdG+Qf7clrKGHf/4eze2kk/wc/jZiAqIUKfAA2XuIqbI5smLeOh/W5aEkj
7pFqS4Gp/vS+41fJ9/hf7/rPp2Gd533hQRMfaXrtbFhfEjj/5tk=
=fZwr
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.