Debian Bug report logs - #1007184
xrt: reproducible builds: Timestamps embedded in version.h

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: xrt: reproducible builds: Timestamps embedded in version.h

Date: Sat, 12 Mar 2022 14:16:59 -0800

[Message part 1 (text/plain, inline)]

Source: xrt
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The build timestamp is embedded in /usr/include/xrt/version.h and
various binaries that make use of this include file:

  https://tests.reproducible-builds.org/debian/rb-pkg/experimental/amd64/diffoscope-results/xrt.html

  static·const·char·xrt_build_version_date_rfc[]·=·"Thu,·10·Mar·2022·00:03:39·-1200";
  vs.
  static·const·char·xrt_build_version_date_rfc[]·=·"Thu,·13·Apr·2023·08:35:26·+1400";
 	 
  static·const·char·xrt_build_version_date[]·=·"2022-01-19·15:01:01";
  vs.
  static·const·char·xrt_build_version_date[]·=·"2022-01-20·17:01:01";


The attached patch fixes this by using cmake's TIMESTAMP feature for
both, and passing the UTC argument for both strings.


With this patch applied, xrt should build reproducibly on
tests.reproducible-builds.org once it migrates to bookworm/testing!

In unstable and experimental, it is additionally affected by varied
build paths.


Thanks for maintaining xrt!


live well,
  vagrant

[0001-src-CMake-version.cmake-Consistently-use-UTC-timezon.patch (text/x-diff, inline)]

From cba92515b6c76f93d792cb0ae246617e4900e42a Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 12 Mar 2022 21:19:21 +0000
Subject: [PATCH] src/CMake/version.cmake: Consistently use UTC timezone for
 timestamps.

While cmake TIMESTAMP respects the SOURCE_DATE_EPOCH environment
variable, it needs to be specified in the UTC timezone otherwise the
local timezone is used.

Convert XRT_DATE_RFC to use cmake TIMESTAMP.

https://reproducible-builds.org/docs/source-date-epoch/
---
 src/CMake/version.cmake | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/CMake/version.cmake b/src/CMake/version.cmake
index b74d30f..64efdba 100644
--- a/src/CMake/version.cmake
+++ b/src/CMake/version.cmake
@@ -33,15 +33,9 @@ execute_process(
 string(REPLACE "\n" "," XRT_MODIFIED_FILES "${XRT_MODIFIED_FILES}")
 
 # Get the build date RFC format
-execute_process(
-  COMMAND date -R
-  WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
-  OUTPUT_VARIABLE XRT_DATE_RFC
-  OUTPUT_STRIP_TRAILING_WHITESPACE
-)
-
+string(TIMESTAMP XRT_DATE_RFC "%a, %d %b %Y %H:%M:%S %Z" UTC)
 
-string(TIMESTAMP XRT_DATE "%Y-%m-%d %H:%M:%S")
+string(TIMESTAMP XRT_DATE "%Y-%m-%d %H:%M:%S" UTC)
 
 
 configure_file(
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1007184-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1007184-close@bugs.debian.org

Subject: Bug#1007184: fixed in xrt 202020.2.8.832+dfsg-2

Date: Tue, 31 May 2022 05:20:58 +0000

Source: xrt
Source-Version: 202020.2.8.832+dfsg-2
Done: Nobuhiro Iwamatsu <iwamatsu@debian.org>

We believe that the bug you reported is fixed in the latest version of
xrt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1007184@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Nobuhiro Iwamatsu <iwamatsu@debian.org> (supplier of updated xrt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 31 May 2022 10:39:44 +0900
Source: xrt
Binary: libxrt-dev libxrt-utils libxrt-utils-dbgsym libxrt1 libxrt1-dbgsym
Architecture: source amd64
Version: 202020.2.8.832+dfsg-2
Distribution: experimental
Urgency: medium
Maintainer: Debian Xilinx Package Maintainers <team+pkg-xilinx@tracker.debian.org>
Changed-By: Nobuhiro Iwamatsu <iwamatsu@debian.org>
Description:
 libxrt-dev - Xilinx Runtime (XRT) - development files
 libxrt-utils - Xilinx Runtime (XRT) - runtime -- utilities
 libxrt1    - Xilinx Runtime (XRT) - runtime libraries
Closes: 1006524 1006596 1007184 1008476
Changes:
 xrt (202020.2.8.832+dfsg-2) experimental; urgency=medium
 .
   * Fix reproducible builds in version.h (Closes: #1007184)
     d/patches/0008-src-CMake-version.cmake-Consistently-use-UTC-timezon.patch.
     Thanks to Vagrant Cascadian <vagrant@reproducible-builds.org>.
   * Fix package long descriptions. (Closes: #1008476, #1006524)
   * Rename /usr/bin/mpd to /usr/bin/xrt_mpd. (Closes: #1006596)
Checksums-Sha1:
 dd02d37ae69280447624aeda538bcb23edcd2289 2499 xrt_202020.2.8.832+dfsg-2.dsc
 c9a382c2fa6afea175f9d13a4d5b01bc56dfb600 12144 xrt_202020.2.8.832+dfsg-2.debian.tar.xz
 6ca54c81c068ff53285633ba49979f60dd445a1e 102164 libxrt-dev_202020.2.8.832+dfsg-2_amd64.deb
 d15d2ada18291ae5fd32a38c1603fc04d2023a24 3063936 libxrt-utils-dbgsym_202020.2.8.832+dfsg-2_amd64.deb
 31514c4b42adca654ac162911bd416177fa6da46 177776 libxrt-utils_202020.2.8.832+dfsg-2_amd64.deb
 6121d62172967593d9f88e44356a4fab75100713 44795272 libxrt1-dbgsym_202020.2.8.832+dfsg-2_amd64.deb
 30c9f1907236cbb47aa82383f6ac42f8245a98b5 2007824 libxrt1_202020.2.8.832+dfsg-2_amd64.deb
 c231bd82ee0e64776fc21f12d98df95beba74bb7 9880 xrt_202020.2.8.832+dfsg-2_amd64.buildinfo
Checksums-Sha256:
 91898f22e338580d37afc7daede951325c0b0cb6de6698532989c42aac77efe9 2499 xrt_202020.2.8.832+dfsg-2.dsc
 33d4c6f222b44e9690f8875c3e4245bd332e5a4358b9048598fb580b943e5a39 12144 xrt_202020.2.8.832+dfsg-2.debian.tar.xz
 6d884c31ab6e0a3c1eb32349ac6726fa9c064adb82752b713712864580a47a95 102164 libxrt-dev_202020.2.8.832+dfsg-2_amd64.deb
 48503dda5ba32429dad38e271465d93226b33b1507bdd9d2666096b924157fd9 3063936 libxrt-utils-dbgsym_202020.2.8.832+dfsg-2_amd64.deb
 77e0dda8fa2cf447bf628a6b54a1c1de42f7cea81aa3a375b7d61472ea24d746 177776 libxrt-utils_202020.2.8.832+dfsg-2_amd64.deb
 597ccfec5682e5eebbb346cba4e45b253db52f7599967778774f678aa39b60ca 44795272 libxrt1-dbgsym_202020.2.8.832+dfsg-2_amd64.deb
 14892cdf50b71f1880558cc64e58309dd9a00dbdc16305cf192884f9a0d598ed 2007824 libxrt1_202020.2.8.832+dfsg-2_amd64.deb
 9eceb3a29f90c47b961f891c160e58c42dbdb85f52fe29db4f0dd5e6f861b0a6 9880 xrt_202020.2.8.832+dfsg-2_amd64.buildinfo
Files:
 0dfbfd154b889444b64f43230f35a3de 2499 libs optional xrt_202020.2.8.832+dfsg-2.dsc
 68aed4ecc7cb92be082ec2a619e568ca 12144 libs optional xrt_202020.2.8.832+dfsg-2.debian.tar.xz
 402b27a69e355732602b07493cb79678 102164 libdevel optional libxrt-dev_202020.2.8.832+dfsg-2_amd64.deb
 a05d4aa4a82689a5a9e1c7a71a8342dc 3063936 debug optional libxrt-utils-dbgsym_202020.2.8.832+dfsg-2_amd64.deb
 bf67ae4d965fc16400f5c568cc2147b4 177776 utils optional libxrt-utils_202020.2.8.832+dfsg-2_amd64.deb
 163507a240bb36e5e1f08ded8257650b 44795272 debug optional libxrt1-dbgsym_202020.2.8.832+dfsg-2_amd64.deb
 aa95bbb683f084b27442a06efdd2234b 2007824 libs optional libxrt1_202020.2.8.832+dfsg-2_amd64.deb
 09d4cdc100f5576dabc5ca6910dcae87 9880 libs optional xrt_202020.2.8.832+dfsg-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXmKe5SMhlzV7hM9DMiR/u0CtH6YFAmKVncsACgkQMiR/u0Ct
H6bA3w//dQh2EbbPyL7K+I+0Zx1Bc5787AE7d5olSnhw3mzlbUi0Qct33VIRj7kS
la+soj8KGwrzeqUvF33sCm2mml6LUJwh0SLJ3Vu9Sz6MWI5eMLFHlCOEXzG/ELlx
AhSOUvS1OAa99ZxYSyjhSX0sRWNZ8vNlkos2DN2GlmKPibbIuKgWzHdNBVafrxSj
nZIjeG822csB4DnmKIVqrbcCY2vIpjEEtYQSZXDVAwmGT/ynEsGMbu1az60fpWdi
nJTIyiLwUoR9vLyNNCYa9ZYm2kQsP3tuLuf+cMJtCZquLQZQ8KvDej7EIZty4v5f
AOvJc/QrTWtRZm6CygAShI5PIy7anPVc7tjhZtRKLXV8SV1L9yu9y+YBczHtlwtq
BvmXh0bR1ifMIJbLaWczqptATMxpxF4LH1zdSP9yUcAYY93l+XLFZEiY7nBeBhNE
e6w7eNkKs4/t8DPl+GX2vwlNCNV9Szs1xcFkvPWiiIQcizMyMmoSI1ibmjEKOOUp
zvPxTKsWWDQQbhr4pad/R9TDX/ZgDosy/E5OAufE1X5BNOukLgGdmx4ICY0+1p5C
G+W/C+XcXC/JXiE+qEnmslNq7P6vKr8Om90/0TC1uwesoxERP6hqMbCLFirz4pKt
g7b15ydT1M42FwK6xAxRZ3dSaHVSW0zohKVtOj97fd/eBLjRoD8=
=E15M
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.