Debian Bug report logs - #1006979
liggghts: reproducible builds: username and timestamp embedded in libliggghts.so.3.8.0

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: liggghts: reproducible builds: username and timestamp embedded in libliggghts.so.3.8.0

Date: Wed, 09 Mar 2022 12:17:33 -0800

[Message part 1 (text/plain, inline)]

Source: liggghts
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: username timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

/usr/lib/x86_64-linux-gnu/libliggghts.so.3.8.0

│ │ │ ├── ./usr/lib/x86_64-linux-gnu/libliggghts.so.3.8.0
...
│ │ │ │ │ -nearestActiveEdgminActiveEdgeDisLIGGGHTS-PUBLIC 3.8.0, compiled 2022-03-09-06:30:52 by vagrant, git commit e2bd90538abe29938\
baf70275ba72f6db429b758
│ │ │ │ │ +nearestActiveEdgminActiveEdgeDisLIGGGHTS-PUBLIC 3.8.0, compiled 2023-05-01-09:19:17 by vagrant, git commit e2bd90538abe29938\
baf70275ba72f6db429b758


The attached two patches fix this by respecting the SOURCE_DATE_EPOCH
environment variable for the timestamp, and by removing the build user
from the information embedded in the binary.


Thanks for maintaining liggghts!


live well,
  vagrant

[0001-src-Make.sh-Use-SOURCE_DATE_EPOCH-for-build-timestam.patch (text/x-diff, inline)]

From aa115db3100bd9814b50d1d2109cc0759baa6d9c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 9 Mar 2022 19:25:35 +0000
Subject: [PATCH 1/2] src/Make.sh: Use SOURCE_DATE_EPOCH for build timestamp.

https://reproducible-builds.org/docs/source-date-epoch/
---
 src/Make.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Make.sh b/src/Make.sh
index 96b57be..0fd32fd 100644
--- a/src/Make.sh
+++ b/src/Make.sh
@@ -11,7 +11,8 @@
 
 style () {
   # modified C.K. create version_liggghts.h
-  builddate=`date +%Y-%m-%d-%H:%M:%S`
+  DATE_FMT='+%Y-%m-%d-%H:%M:%S'
+  builddate=`date -u -d "@$SOURCE_DATE_EPOCH" "$DATE_FMT" 2>/dev/null || date -u -r "$SOURCE_DATE_EPOCH" "$DATE_FMT" 2>/dev/null || date -u "$DATE_FMT"`
   wai=`whoami`
   vers=`cat version_liggghts.txt`
   bra=`cat version_liggghts_branch.txt`
-- 
2.35.1

[0002-src-Make.sh-Do-not-embed-build-user.patch (text/x-diff, inline)]

From 05e0cb096e8c5c4581fb81f86e08fcdc52d9aef7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 9 Mar 2022 20:05:22 +0000
Subject: [PATCH 2/2] src/Make.sh: Do not embed build user.

---
 src/Make.sh | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/Make.sh b/src/Make.sh
index 0fd32fd..147e123 100644
--- a/src/Make.sh
+++ b/src/Make.sh
@@ -13,20 +13,19 @@ style () {
   # modified C.K. create version_liggghts.h
   DATE_FMT='+%Y-%m-%d-%H:%M:%S'
   builddate=`date -u -d "@$SOURCE_DATE_EPOCH" "$DATE_FMT" 2>/dev/null || date -u -r "$SOURCE_DATE_EPOCH" "$DATE_FMT" 2>/dev/null || date -u "$DATE_FMT"`
-  wai=`whoami`
   vers=`cat version_liggghts.txt`
   bra=`cat version_liggghts_branch.txt`
 
   if [ -d .git ]; then
     githash=`git log -1 --format="%H"`
-    echo "#define LIGGGHTS_VERSION \"$bra $vers, compiled $builddate by $wai, git commit $githash\"" > version_liggghts.h
+    echo "#define LIGGGHTS_VERSION \"$bra $vers, compiled $builddate, git commit $githash\"" > version_liggghts.h
   elif [ -d ../.git ]; then
     cd ..    
     githash=`git log -1 --format="%H"`
     cd src
-    echo "#define LIGGGHTS_VERSION \"$bra $vers, compiled $builddate by $wai, git commit $githash\"" > version_liggghts.h
+    echo "#define LIGGGHTS_VERSION \"$bra $vers, compiled $builddate, git commit $githash\"" > version_liggghts.h
   else
-    echo "#define LIGGGHTS_VERSION \"$bra $vers, compiled $builddate by $wai, git commit unknown\"" > version_liggghts.h
+    echo "#define LIGGGHTS_VERSION \"$bra $vers, compiled $builddate, git commit unknown\"" > version_liggghts.h
   fi;
 
   list=`grep -sl $1 $2*.h`
-- 
2.35.1

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.