Debian Bug report logs - #1006474
foma: reproducible-builds: build path embedded in libfoma.pc

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: foma: reproducible-builds: build path embedded in libfoma.pc

Date: Fri, 25 Feb 2022 16:45:56 -0800

[Message part 1 (text/plain, inline)]

Source: foma
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

A typo in the Makefile results in the build path getting embedded in
libfoma.pc:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/foma.html

  /usr/lib/x86_64-linux-gnu/pkgconfig/libfoma.pc

  prefix=/build/1st/foma-0.10.0/debian/tmp/usr
  vs.
  prefix=/build/2/foma-0.10.0/2nd/debian/tmp/usr

The attached patches fix this by fixing the typo in the Makefile.


With this patch applied, foma should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining foma!


live well,
  vagrant

[0001-Makefile-Fix-typo-when-generating-libfoma.pc.patch (text/x-diff, inline)]

From a799f7aab5e81c839f5be79e1512c6e8b9691e6f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 26 Feb 2022 00:40:58 +0000
Subject: [PATCH] Makefile: Fix typo when generating libfoma.pc.

The value of prefix isn't sufficienltly quoted for the Makefile, and
results in the build path getting embedded in the installed .pc file.
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index df2ed12..2c2bdcb 100644
--- a/Makefile
+++ b/Makefile
@@ -95,7 +95,7 @@ install: foma libfoma libfoma.pc
 $(OBJS): foma.h
 
 libfoma.pc:
-	echo "prefix=${prefix}" > $@
+	echo "prefix=$${prefix}" > $@
 	echo 'exec_prefix=$${prefix}' >> $@
 	echo 'includedir=$${prefix}/include' >> $@
 	echo 'libdir=$${exec_prefix}/lib' >> $@
-- 
2.35.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1006474-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1006474-close@bugs.debian.org

Subject: Bug#1006474: fixed in foma 1:0.10.0-2

Date: Thu, 03 Mar 2022 05:33:45 +0000

Source: foma
Source-Version: 1:0.10.0-2
Done: Kartik Mistry <kartik@debian.org>

We believe that the bug you reported is fixed in the latest version of
foma, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1006474@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Kartik Mistry <kartik@debian.org> (supplier of updated foma package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 02 Mar 2022 17:21:19 +0530
Source: foma
Architecture: source
Version: 1:0.10.0-2
Distribution: unstable
Urgency: low
Maintainer: Debian Science Team <debian-science-maintainers@alioth-lists.debian.net>
Changed-By: Kartik Mistry <kartik@debian.org>
Closes: 1006474
Changes:
 foma (1:0.10.0-2) unstable; urgency=low
 .
   * Added patch to fix reproducible-builds. Thanks Vagrant Cascadian
     <vagrant@reproducible-builds.org>. (Closes: #1006474)
Checksums-Sha1:
 39d3f9a4123ffa3f12b41b58eb14dc7de3db315b 2225 foma_0.10.0-2.dsc
 f26fc5ecae0ee7e1dc09e9e09af863bbe2e5890b 3804 foma_0.10.0-2.debian.tar.xz
Checksums-Sha256:
 c04e8005e9f35f36f84107ea22a315221667ef831eaf631d938378fe20b2c350 2225 foma_0.10.0-2.dsc
 dd377aa24b55cf861254adac7b84e8e56bb0dc0598531b2f65e5340c513f6734 3804 foma_0.10.0-2.debian.tar.xz
Files:
 c8f3bf97d40f844659384896e523398a 2225 science optional foma_0.10.0-2.dsc
 66224c3a001fb09b4269d144c998d031 3804 science optional foma_0.10.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEa2MbXvVUr2sRlmKSAsHT8ng6pN4FAmIgT3IACgkQAsHT8ng6
pN62UxAAmpRUB1jS6OohkeIGI9N2ykjBxTWLjM/xbXELA7nKMRjpYyMs4FkzaGUF
aS06UB2W5WvMFh4s/3ntx5C+l7buprTCYKJwmqrweEwlk/CJFiJoqvxueB/7JKbN
poUiUBVSacO2MbGpkzQinuy/YC9Fz6ypcuI7K2+5Khpr93mU8Y6VVCgrsWzc+3Ab
khnyMYyZYn18/gvBYHKXBlKKX3Ihih1C5WVmvmqxkHwl9GUhXB7XE5rBWZhkmjC5
ADZUOborMUKTT8j0FTfhUfuQJ2A/PI+7yvny3kPvGjl5tUH2Kb47CAxgZ/onBPs/
IHbD023NmUOQMqhsap/uSG8qDt6CXnf8PCoDXNQprOaULXUlPZWGAAP8gPmXHzgG
O24vYvAIhOpv43e6vhzoUe96bFu+u3XcvSWad5UxKx3ZbAUWCiazlDEB/5z61Knu
loikWrbhuQmZIaVOeQy39WYRMzPZ3CTmAFKbAzwbi4NBwbCHOX0rtX3X7LZb1lCN
1syhA6qTee+2j1izRQ3pYHybRQHMLpMgYIm94j7KkncxTWeEbtHIZDqxMgU5KbDd
8wI5831qvYAlzah9O/oePKv6OG6t3vwgYzelMOhI4ID9jfQXXR1+Rlddb87zjeDd
NtboRmnkcXuY8kCoWIisLzrHYvm+2Lv5SDrCGNwbnzVWx37Pjck=
=ImPS
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.