Debian Bug report logs - #1005955
paper-icon-theme: please make the build reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: paper-icon-theme: please make the build reproducible

Date: Thu, 17 Feb 2022 17:47:08 -0800

[Message part 1 (text/plain, inline)]

Source: paper-icon-theme
Version: 1.5.0+git20200312.aa3e8af-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: filesystem
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0] we noticed that
paper-icon-theme could not be built reproducibly.

This is caused by jdupes iterating over its arguments using the
filesystem ordering, instead of using their filenames. A patch is
attached that sorts the input prior to passing it to jdupes (using
find, sort and xargs), but it may be more sensible that jdupes does
this itself. Indeed, the jdupes manpage implies that it should do
this, but I leave this up to your (almost certainly more informed)
judgement.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[paper-icon-theme.diff.txt (text/plain, attachment)]

Message #10 received at 1005955@bugs.debian.org (full text, mbox, reply):

From: Carlos Henrique Lima Melara <charlesmelara@outlook.com>

To: lamby@debian.org

Cc: 1005955@bugs.debian.org

Subject: Re: paper-icon-theme: please make the build reproducible

Date: Wed, 2 Mar 2022 23:07:31 -0300

[Message part 1 (text/plain, inline)]

Hi, Chris.

On Thu, 17 Feb 2022 17:47:08 -0800 "Chris Lamb" <lamby@debian.org> wrote:
> Whilst working on the Reproducible Builds effort [0] we noticed that
> paper-icon-theme could not be built reproducibly.
> 
> This is caused by jdupes iterating over its arguments using the
> filesystem ordering, instead of using their filenames. A patch is
> attached that sorts the input prior to passing it to jdupes (using
> find, sort and xargs), but it may be more sensible that jdupes does
> this itself. Indeed, the jdupes manpage implies that it should do
> this, but I leave this up to your (almost certainly more informed)
> judgement.

Thanks for contacting about this. Indeed, it would be better to fix it
upstream. I've opened a bug against jdupes [1] when I realized the
reproducibility issue and the upstream developer acknowledge it, placing
it in the roadmap, though I don't think he had the time to fix it yet.

I just would like to know if you tested the patch? I've seem that it
happens in x86_32 and armhf, but I don't have the hardware to test the
fix. Also would like to ask if I can forward your email to [1] and the
upstream developer.

Thanks for the patch,
Charles

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975684

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 1005955@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Carlos Henrique Lima Melara" <charlesmelara@outlook.com>

Cc: 1005955@bugs.debian.org

Subject: Re: paper-icon-theme: please make the build reproducible

Date: Thu, 03 Mar 2022 18:25:07 -0000

Hi Carlos,

> Thanks for contacting about this. Indeed, it would be better to fix it
> upstream. I've opened a bug against jdupes [1] when I realized the
> reproducibility issue and the upstream developer acknowledge it, placing
> it in the roadmap, though I don't think he had the time to fix it yet.

Ah yes; in retrospect, I perhaps should have filed this directly
against jdupes myself (or found the existing bug). Thank you for doing
that.

> I just would like to know if you tested the patch? I've seem that it
> happens in x86_32 and armhf, but I don't have the hardware to test the
> fix.

I tested the patch, yes; does it not work for you? The difference
between architectures could simply be a difference in the
reproducibility variations applied on that particular architecture. Or
the differences could be merely an example of the nondeterminism
itself.

> Also would like to ask if I can forward your email to [1] and the
> upstream developer.

Sure, if you think it might help.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #20 received at 1005955-quiet@bugs.debian.org (full text, mbox, reply):

From: Carlos Henrique Lima Melara <charlesmelara@outlook.com>

To: Chris Lamb <lamby@debian.org>

Cc: 1005955-quiet@bugs.debian.org

Subject: Re: paper-icon-theme: please make the build reproducible

Date: Mon, 7 Mar 2022 23:09:29 -0300

[Message part 1 (text/plain, inline)]

Hi, Chris.

On Thu, Mar 03, 2022 at 06:25:07PM -0000, Chris Lamb wrote:
> > I just would like to know if you tested the patch? I've seem that it
> > happens in x86_32 and armhf, but I don't have the hardware to test the
> > fix.
> 
> I tested the patch, yes; does it not work for you? The difference
> between architectures could simply be a difference in the
> reproducibility variations applied on that particular architecture. Or
> the differences could be merely an example of the nondeterminism
> itself.

Actually, I wasn't able to reproduce this issue on my machine. I tested
back when the issue appeared and now that you submitted the patch and
the builds on my machine are identical. I've applied the patch and
pushed it to salsa to execute the CI pipeline. It passed the reprotest
test, so I think it solves the bug - thanks!

This bug should be closed in the next upload.

Cheers,
Charles

[signature.asc (application/pgp-signature, inline)]

Message #27 received at 1005955-quiet@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Carlos Henrique Lima Melara" <charlesmelara@outlook.com>

Cc: 1005955-quiet@bugs.debian.org

Subject: Re: paper-icon-theme: please make the build reproducible

Date: Tue, 08 Mar 2022 12:49:02 -0000

Hi Carlos,

> Actually, I wasn't able to reproduce this issue on my machine. I tested
> back when the issue appeared and now that you submitted the patch and
> the builds on my machine are identical.

Ah, perhaps I could have helped here: given this is a filesystem
ordering issue, it's unsurprising that you could not easily reproduce
it locally.

Unless you use disorderfs or similar, most file systems will happen to
return directory entries in the same order if asked multiple times in
a row — the underlying problem is that this is not defined and/or
deterministic.


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #32 received at 1005955-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1005955-close@bugs.debian.org

Subject: Bug#1005955: fixed in paper-icon-theme 1.5.0+git20200312.aa3e8af-4

Date: Sun, 17 Jul 2022 19:49:08 +0000

Source: paper-icon-theme
Source-Version: 1.5.0+git20200312.aa3e8af-4
Done: Carlos Henrique Lima Melara <charlesmelara@outlook.com>

We believe that the bug you reported is fixed in the latest version of
paper-icon-theme, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1005955@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Carlos Henrique Lima Melara <charlesmelara@outlook.com> (supplier of updated paper-icon-theme package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 17 Jul 2022 13:22:46 -0300
Source: paper-icon-theme
Architecture: source
Version: 1.5.0+git20200312.aa3e8af-4
Distribution: unstable
Urgency: medium
Maintainer: Carlos Henrique Lima Melara <charlesmelara@outlook.com>
Changed-By: Carlos Henrique Lima Melara <charlesmelara@outlook.com>
Closes: 1005955
Changes:
 paper-icon-theme (1.5.0+git20200312.aa3e8af-4) unstable; urgency=medium
 .
   * debian/control: bumped Standards-Version to 4.6.1.
   * debian/copyright: updated packaging copyright years.
   * debian/rules: added patch to build reproducible. Thanks to Chris Lamb.
     (Closes: #1005955)
   * debian/watch: updated regex accordingly to new github releases location.
Checksums-Sha1:
 7ca8f5620c742d60269da9af06d024995afb4996 2092 paper-icon-theme_1.5.0+git20200312.aa3e8af-4.dsc
 c3abd5d965f62ac1c470bf0544057e237bd47dc0 14280 paper-icon-theme_1.5.0+git20200312.aa3e8af-4.debian.tar.xz
 410be864c28e9cd71e16359578822c1b7aac729b 6855 paper-icon-theme_1.5.0+git20200312.aa3e8af-4_amd64.buildinfo
Checksums-Sha256:
 ad6c6e0e3ba7abcf483b81530f9f890a5f0fac47b9f65b20009837272874d1af 2092 paper-icon-theme_1.5.0+git20200312.aa3e8af-4.dsc
 e07acf88bef036f08e5c06410b213a619acc76cafd9202e87407c0c08e86833b 14280 paper-icon-theme_1.5.0+git20200312.aa3e8af-4.debian.tar.xz
 70caecef74967b6948c036994a47fd89915274d852b6008a15ed35913924ac50 6855 paper-icon-theme_1.5.0+git20200312.aa3e8af-4_amd64.buildinfo
Files:
 e6c04a210ebac305af5417339adeaf21 2092 x11 optional paper-icon-theme_1.5.0+git20200312.aa3e8af-4.dsc
 99e55ed61850fc6f2d2edb669a28f282 14280 x11 optional paper-icon-theme_1.5.0+git20200312.aa3e8af-4.debian.tar.xz
 e4db6808639bf9c7a2ba2a2b20e8b52b 6855 x11 optional paper-icon-theme_1.5.0+git20200312.aa3e8af-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEBdtqg34QX0sdAsVfu6n6rcz7RwcFAmLUY0gACgkQu6n6rcz7
Rwc5QQ/+NF8oBN+rNAscPitrOVnjLocmY8HIS8jDd82XPXBoKPXNhgkqZ/8CAl7C
HMIxCSe3jCLQAzv4hxJWrmSjXRlh4RB4zXmxRXh4XEvocUsYMwpPgCB+oiuChXfG
gH2jsnJGPdXiUOp4n5sgjRWyX7OOaeiMkKWfsoAg15h6U2uglOm7K/LexbKIdcu3
/c4TnibFWTB/WP0tlcMBmiPuQdXyvYDaLzABQnC8S1A++MLLNoG+1C4qniVqfdjh
SKTHBmRt9NoX6kO5+EXdX3858pW1NKp+Ge7e/kCVvR5UuW5Nh7NEWFpT8oD+n8SF
UBA4QqAKxDT8P2RdRvwZmhqauKu6i5e2qWQwsC9Li+M9KCaap1cuU78mHp3MCugS
E+ck2j2zJtlwmlYdjOH9cgcpU8FKvt/Z70bzpZ+HCy+j/8RFbr37Dg78BXR2ei60
+4JdhI7Sl1xxXCnSdEPOm8Ws17WpWLTnu6XNJ1anYpVbIAn+W7t5mJm//Avc37j0
hL+/Twl6c81+h7XkwU+kSsq3lVrKIpiUrvt4dhW5SbqjvVeOPVhgYojyb0NXC108
t5OPXPCjLFOk4b55cv57vnRD9FCVZsLo88FIFkeUa/h/KD+Nvn0kK16B96g51W73
lgnPAVAC8KQ5bpGXsVDIDl3fvFu9uQ3lZT7r+XWdl6qgfOlCFuc=
=3rMC
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.