Debian Bug report logs - #1005793
libadwaita-1: reproducible builds: Embedded date in .xml file

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: libadwaita-1: reproducible builds: Embedded date in .xml file

Date: Mon, 14 Feb 2022 17:16:06 -0800

[Message part 1 (text/plain, inline)]

Source: libadwaita-1
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The file /usr/share/metainfo/org.gnome.Adwaita1.Demo.metainfo.xml
contains an embedded build date:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libadwaita-1.html

  <release·version="1.0.2"·date="2023-03-19">
  vs.
  <release·version="1.0.2"·date="2022-02-15">

The attached patch fixes this by removing the call to date from the
meson.build file.


An alternate option would be to use the SOURCE_DATE_EPOCH environment
variable, and there is a meson example available:

  https://reproducible-builds.org/docs/source-date-epoch/

This would be better if the package somehow fails to work correctly when
there is no date in this file, though ideally no timestamp would be
better if possible.


With this patch applied, libadwaita-1 should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining libadwaita-1!


live well,
  vagrant

[0001-demo-data-meson.build-Remove-build-date.patch (text/x-diff, inline)]

From c0be5862ff331f874e674a041209451f91329ed6 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 15 Feb 2022 01:06:49 +0000
Subject: [PATCH] demo/data/meson.build: Remove build date.

The build date does not appear to be required, and makes the build
unreproducible when built on a different date.
---
 demo/data/meson.build | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/demo/data/meson.build b/demo/data/meson.build
index 612410c5..55b4152c 100644
--- a/demo/data/meson.build
+++ b/demo/data/meson.build
@@ -15,14 +15,6 @@ if desktop_utils.found()
 endif
 
 today = 'unknown'
-date = find_program('date',
-         required: false)
-if date.found()
-  r = run_command(date, '-I')
-  if r.returncode() == 0
-    today = r.stdout().strip()
-  endif
-endif
 
 appdata_config = configuration_data()
 appdata_config.set('BUILD_VERSION', meson.project_version())
-- 
2.34.1

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.