Debian Bug report logs - #1005792
btop: reproducible-builds: Build path embedded in /usr/bin/btop

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: btop: reproducible-builds: Build path embedded in /usr/bin/btop

Date: Mon, 14 Feb 2022 17:05:02 -0800

[Message part 1 (text/plain, inline)]

Source: btop
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Different build paths trigger reproducibility issues with binaries such
as /usr/bin/btop and relevent debugging symbols.

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/btop.html

  /build/1st/btop-1.1.3/include/robin_hood.h:2296
  vs.
  /build/2/btop-1.1.3/2nd/include/robin_hood.h:2296

The attached patch fixes this by passing -ffile-prefix-map via the
ADDFLAGS variable (documented in btop/README.md) to avoid embedding the
build path into the binaries.

Another option might be to pass CXXFLAGS via ADDFLAGS with the default
values that debhelper/dpkg-buildflags get.


With this patch applied, btop should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining btop!


live well,
  vagrant

[0001-debian-rules-Remove-embedded-build-paths-by-passing-.patch (text/x-diff, inline)]

From 3263f2b38bc106bdd7da289be6296e625f50ab4f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 15 Feb 2022 00:52:34 +0000
Subject: [PATCH] debian/rules: Remove embedded build paths by passing
 -ffile-prefix-map via ADDFLAGS variable.

https://reproducible-builds.org/docs/build-path/
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index b80fa90..c9ca95a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,7 @@
 #export DH_VERBOSE = 1
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 export DEB_CFLAGS_MAINT_APPEND  = -Wall -pedantic
+export ADDFLAGS = -ffile-prefix-map=$(CURDIR)=.
 
 %:
 	dh $@
-- 
2.34.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1005792@bugs.debian.org (full text, mbox, reply):

From: Marius Gripsgard <marius@ubports.com>

To: 1005792@bugs.debian.org

Subject: applied

Date: Sun, 20 Feb 2022 20:15:39 +0000

[Message part 1 (text/plain, inline)]

Thank you, applied :)


- Marius Gripsgard

[OpenPGP_0xBAF9CEC3F6922789.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #15 received at 1005792-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1005792-close@bugs.debian.org

Subject: Bug#1005792: fixed in btop 1.2.3-2

Date: Sun, 20 Feb 2022 20:48:45 +0000

Source: btop
Source-Version: 1.2.3-2
Done: Marius Gripsgard <marius@ubports.com>

We believe that the bug you reported is fixed in the latest version of
btop, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1005792@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marius Gripsgard <marius@ubports.com> (supplier of updated btop package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 20 Feb 2022 21:08:26 +0100
Source: btop
Architecture: source
Version: 1.2.3-2
Distribution: unstable
Urgency: medium
Maintainer: Marius Gripsgard <marius@ubports.com>
Changed-By: Marius Gripsgard <marius@ubports.com>
Closes: 1005792
Changes:
 btop (1.2.3-2) unstable; urgency=medium
 .
   [ Vagrant Cascadian ]
   * debian/rules: Remove embedded build paths by passing -ffile-prefix-map
     via ADDFLAGS variable. (closes: #1005792)
Checksums-Sha1:
 0bf8ecec474bf83ef8d910e3763f154a188d6352 1831 btop_1.2.3-2.dsc
 9b6f0c91385d5e06bf6436c0c4c22cb3037ffae7 970713 btop_1.2.3.orig.tar.gz
 8cb1c6185d7fcd5cbc1b0d0934e2655b9ae60c76 4252 btop_1.2.3-2.debian.tar.xz
 87a36112978308cd4e47616a011b5a8a7ef9afa2 5872 btop_1.2.3-2_source.buildinfo
Checksums-Sha256:
 852e88f98b35075f0f4d880a0b739cda4a93a7015628359d17686ef28dec4f03 1831 btop_1.2.3-2.dsc
 8348bb37b642bf899b5ce0850d64e12cf9671c8c9624f3d21b58a015cd502107 970713 btop_1.2.3.orig.tar.gz
 f7cf6ae1eb8726b732790b741990dafd219e37b0d63ecfe265114eacff4ec251 4252 btop_1.2.3-2.debian.tar.xz
 4285cb3cb5abc75eb311e13083a0b3190318a21c945fb96e51a87b3b27fa2857 5872 btop_1.2.3-2_source.buildinfo
Files:
 0ee84aa5dfd573fb5828192045eceac0 1831 utils optional btop_1.2.3-2.dsc
 7040baa28396be2eac70d573197981c4 970713 utils optional btop_1.2.3.orig.tar.gz
 a0162caa5d091c2dafb86483b9b32530 4252 utils optional btop_1.2.3-2.debian.tar.xz
 b19084a275745fde3515d00d0ca6d034 5872 utils optional btop_1.2.3-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEm65oPpnDJVLXb56DuvnOw/aSJ4kFAmISoNATHG1hcml1c0B1
YnBvcnRzLmNvbQAKCRC6+c7D9pIniZ+nEACxhzaPdi5wfw7dZblirdht4BV57RxI
crjcCtzrOThqs0JEcBi+zFG7rjmkVJR5pvWQXo7d3fu4v8/gkOcdQpmnMzKk0sv6
YM20bQSaVA2M8QnDGrCT/UWGTIcSk3J2zSAhTHAAGV38APYFarXwi08ABL/CdswK
JSgGtY+ZNc5gdRVV+JfIDTzePCJs4f3zWUXF+gyUWPHUvFf9OqycQldbjP9Zdv+r
XrUXostEXQ1E9iYfkiHAsFaCzxnlm6Wpvpy0nP4XCh022FwH/E8gxAYQHsWD5+fN
Cpy8CadP1oWVGJFSigqTtwSVZrGEQ5Tys1hS7esbaIH3OQfyqPD5NBZ5uHFeEteI
l2RtCM72yc5SUtIxhVZlVE3LxH13OoMq9KfbS4+3pJuoLBbyT3VLYivJ5lt01osv
Tk8J/EcAF58CCdOhqetsc4menixyNPc/n+qDOxqpqweXPvmNnNvGLdVMJgqUsqrT
V02/XPyWbiQqygC8sBmQUFHD7aIcLrnuqc8M1JiwepWI+K0ZL2LTtX1HUaavTRBd
ny5fvchWfoebJHk7UKcA6dBDfB4PqoIIvZPOvPpyIbvkMz9v7mouED5pCpJh2e+G
6iYcgWQwSNfWmPtEoxaM/zbm7XdoXrGOaCW0MIAy2pQiwRgKK1YPfiQQXkE0XZVA
pVVyr1SS4IQ//A==
=ahsm
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.