Debian Bug report logs - #1004004
darkradiant: reproducible-builds: BuildId differences triggered by RPATH

version graph

Package: src:darkradiant; Maintainer for src:darkradiant is Debian Games Team <pkg-games-devel@lists.alioth.debian.org>;

Reported by: Vagrant Cascadian <vagrant@reproducible-builds.org>

Date: Wed, 19 Jan 2022 07:42:01 UTC

Severity: normal

Tags: patch

Fixed in version darkradiant/2.14.0-3

Done: Tobias Frost <tobi@debian.org>

Bug is archived. No further changes may be made.

Toggle useless messages

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to debian-bugs-dist@lists.debian.org, reproducible-bugs@lists.alioth.debian.org, Debian Games Team <pkg-games-devel@lists.alioth.debian.org>:
Bug#1004004; Package src:darkradiant. (Wed, 19 Jan 2022 07:42:03 GMT) (full text, mbox, link).


Acknowledgement sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
New Bug report received and forwarded. Copy sent to reproducible-bugs@lists.alioth.debian.org, Debian Games Team <pkg-games-devel@lists.alioth.debian.org>. (Wed, 19 Jan 2022 07:42:03 GMT) (full text, mbox, link).


Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>
To: submit@bugs.debian.org
Subject: darkradiant: reproducible-builds: BuildId differences triggered by RPATH
Date: Tue, 18 Jan 2022 23:39:55 -0800
[Message part 1 (text/plain, inline)]
Source: darkradiant
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/darkradiant.html

The attached patch to debian/rules passes
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
which should use a relative path for RPATH.

Alternately, updating the packaging to debhelper compat level 14 should
fix this, although it is currently an experimental compat level.

With this patch applied, darkradiant should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining darkradiant!

live well,
  vagrant
[0001-debian-rules-Pass-DCMAKE_BUILD_RPATH_USE_ORIGIN-ON-v.patch (text/x-diff, inline)]
From 669e0cbcc0a6d968c99309d65b8f4ea81730c9f0 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Wed, 19 Jan 2022 07:37:33 +0000
Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure override.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 42eb66c..ec74f31 100755
--- a/debian/rules
+++ b/debian/rules
@@ -21,3 +21,6 @@ override_dh_install:
 
 override_dh_missing:
 	dh_missing --fail-missing
+
+override_dh_auto_configure:
+	dh_auto_configure -- -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON
-- 
2.34.1

[signature.asc (application/pgp-signature, inline)]

Reply sent to Tobias Frost <tobi@debian.org>:
You have taken responsibility. (Sat, 22 Jan 2022 09:39:03 GMT) (full text, mbox, link).


Notification sent to Vagrant Cascadian <vagrant@reproducible-builds.org>:
Bug acknowledged by developer. (Sat, 22 Jan 2022 09:39:03 GMT) (full text, mbox, link).


Message #10 received at 1004004-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
To: 1004004-close@bugs.debian.org
Subject: Bug#1004004: fixed in darkradiant 2.14.0-3
Date: Sat, 22 Jan 2022 09:34:15 +0000
Source: darkradiant
Source-Version: 2.14.0-3
Done: Tobias Frost <tobi@debian.org>

We believe that the bug you reported is fixed in the latest version of
darkradiant, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1004004@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Tobias Frost <tobi@debian.org> (supplier of updated darkradiant package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 22 Jan 2022 10:12:38 +0100
Source: darkradiant
Architecture: source
Version: 2.14.0-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-devel@lists.alioth.debian.org>
Changed-By: Tobias Frost <tobi@debian.org>
Closes: 1004004
Changes:
 darkradiant (2.14.0-3) unstable; urgency=medium
 .
   * Make build reproducible: BuildId differences triggered by RPATH"
     Thanks to Vagrant for the patch! (Closes: #1004004)
Checksums-Sha1:
 33d8ec679c5aeb9a94e4ed33307b9be4064653db 2434 darkradiant_2.14.0-3.dsc
 84c534551c6f4c26a6d860f5e049a2832bb05c20 9508 darkradiant_2.14.0-3.debian.tar.xz
 bfcbf925880ccd71648f1bac0c1de050168737b0 6072 darkradiant_2.14.0-3_source.buildinfo
Checksums-Sha256:
 3043f6ae57e7b3b182b11e7d6400d361e390146fddd9498dbedb6dda481602f3 2434 darkradiant_2.14.0-3.dsc
 93932dc95836572f4aabe82d6a461584e76d97e5ed010e2043f7497d26680770 9508 darkradiant_2.14.0-3.debian.tar.xz
 d7a9d35a5ac98f79790f2f37d11433068f872eea4c6fff7f6c9a283f753dcd5c 6072 darkradiant_2.14.0-3_source.buildinfo
Files:
 f9e1b2bd358215484fa9cf79b626df93 2434 graphics optional darkradiant_2.14.0-3.dsc
 a7c6ebcf2e1e637f0541e9364808e026 9508 graphics optional darkradiant_2.14.0-3.debian.tar.xz
 fdb9715c7ad495a9278dc352a98e6299 6072 graphics optional darkradiant_2.14.0-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE/d0M/zhkJ3YwohhskWT6HRe9XTYFAmHrypwACgkQkWT6HRe9
XTbFchAAzSyX4PHO3hEZSsn0S0KmWlT5BuUJOJttfDaySXqLuCk12Kzn6Hh5iTvZ
9AWBSxJBJbeVyr2sxOhQgGddonklCcyONmJmqIRxlNkGl/VFvrn/2vpM+E+IP9zq
s0CeLf13wMkSxCa/1EYbKg0WtlKBktncIBWwCP5UwjdWI10BH5kF7vEzCJ/XrqjU
nSvhOMbOG1j4AMqNwg2OMGzb+2o3nV0Ch2B8DnKpDJ4Ut666KODJszfCPxF+4tQm
T+PuH5gljOfHnWJvM9DNkCXFuAZDtPCiGBRR07Ki8oh+Q/RFqY03lRCrRvQ6IP2Q
JGM/AhH702b0OVQoG9x486xqYZZBNBcEPstwN+FbWdGxy23s56PvkpXnFtEKz5oc
lq77FzRYUbyJtvWhNo9URP2Ekae35uIkWBtwQ94SkhX0z6LxY0UhDeKu+BdjnsVz
0HHHJDNuK2x1GUvJbWlzBY3v93bZptt9TiSCTVtCXRFbTjpVL9IVlyDTvZ0zsfdP
H3PGY689ydhWSvtqr2MJKa0V7Pzs6lipJ2HrhSOiiEfz7aUl9KR7dVNxPb+qPdVp
PwNRt/tKNI3GKbZTPSaDwTawfvSa9Tzl6uBHimFFKS85zOWiC1aWsA3MXhdv3AyC
PVW7RrpzbkA9/ROK8KtC7Y5rpMOXf8229c7tOXHCWCJgbidM5T4=
=Qeua
-----END PGP SIGNATURE-----




Bug archived. Request was from Debbugs Internal Request <owner@bugs.debian.org> to internal_control@bugs.debian.org. (Sun, 20 Feb 2022 07:24:51 GMT) (full text, mbox, link).


Send a report that this bug log contains spam.


Debian bug tracking system administrator <owner@bugs.debian.org>. Last modified: Wed May 17 11:04:12 2023; Machine Name: buxtehude

Debian Bug tracking system

Debbugs is free software and licensed under the terms of the GNU Public License version 2. The current version can be obtained from https://bugs.debian.org/debbugs-source/.

Copyright © 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson, 2005-2017 Don Armstrong, and many other contributors.