Debian Bug report logs - #1003787
pesign: reproducible-builds: build path embedded in include

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: pesign: reproducible-builds: build path embedded in include

Date: Sat, 15 Jan 2022 12:55:07 -0800

[Message part 1 (text/plain, inline)]

Source: pesign
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

pesign does not appear to build reproducibly in unstable due to build
paths (which is not varied in testing/bookworm):

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/pesign.html

This appears due to an include directory that embeds the full path.


The attached patch fixes this by passing a relative path to the include
directory in Make.defaults.


With this patch applied, pesign should build reproducibly on
tests.reproducible-builds.org!


Thanks for maintaining pesign!

live well,
  vagrant

[0001-Make.defaults-Use-relative-path-to-include-dir.patch (text/x-diff, inline)]

From f5cb0d11f73a3b3b6b6c58b8f96ebb3da58bf5d0 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sat, 15 Jan 2022 20:43:57 +0000
Subject: [PATCH] Make.defaults: Use relative path to include dir.

This allows for reproducible builds even when the build path differs
between two builds.

https://reproducible-builds.org/docs/build-path/
---
 Make.defaults | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Make.defaults b/Make.defaults
index c97b452..9986da9 100644
--- a/Make.defaults
+++ b/Make.defaults
@@ -40,7 +40,7 @@ cflags	= $(CFLAGS) $(ARCH3264) \
 	-Wno-unused-function\
 	-std=gnu11 -fshort-wchar -fPIC -flto -fno-strict-aliasing \
 	-fno-merge-constants -fkeep-inline-functions \
-	-D_GNU_SOURCE -DCONFIG_$(ARCH) -I${TOPDIR}/include \
+	-D_GNU_SOURCE -DCONFIG_$(ARCH) -I../include \
 	$(if $(filter $(CC),clang),$(clang_cflags), ) \
 	$(if $(filter $(CC),gcc),$(gcc_cflags), ) \
 	$(call pkg-config-cflags) -Werror
-- 
2.34.1

[signature.asc (application/pgp-signature, inline)]

Send a report that this bug log contains spam.