Debian Bug report logs - #1003501
gcc-sh-elf: reproducible builds: copyright files vary depending on /bin/sh symlink

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: gcc-sh-elf: reproducible builds: copyright files vary depending on /bin/sh symlink

Date: Mon, 10 Jan 2022 20:39:28 -0800

[Message part 1 (text/plain, inline)]

Source: gcc-sh-elf
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: shell
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The copyright files shipped in gcc-sh-elf vary depending on which shell
/bin/sh points to:

  https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/gcc-sh-elf.html

  ./usr/share/doc/gcc-sh-elf/copyright

  ... s/GPL-3'...-----
vs.
  ... s/GPL-3'..\n----

Patch attached which adjust the debian/rules target to use plain "echo"
rather than "echo -n", which appears to be less dependent on shell
behavior.


This patch alone does not fix all reproducibility issues (e.g. build
paths, which are only tested on unstable and experimental), but with
this patch and the patch recently submitted addressing usrmerge issues:

  https://bugs.debian.org/1003500


... gcc-sh-elf should become reproducible when it migrates to
bookworm/testing!


Thanks for maintaining gcc-sh-elf!


live well,
  vagrant

[0002-debian-rules-Adjust-copyright-generation-targets-to-.patch (text/x-diff, inline)]

From 6a64475767670e5dd1eafd113b9fd60fcfcbd6e4 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Tue, 11 Jan 2022 04:26:20 +0000
Subject: [PATCH 2/2] debian/rules: Adjust copyright generation targets to use
 plain "echo" instead of "echo -n".

The behavior of "echo -n" may be shell dependent, resulting in
different builds depending one which shell /bin/sh points to.
---
 debian/rules | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/debian/rules b/debian/rules
index 0c06730..4cefb1c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -97,17 +97,20 @@ override_dh_auto_install:
 execute_before_dh_installdocs: debian/gcc-$(gnu_type).copyright debian/libnewlib-$(gnu_type)-dev.copyright
 debian/gcc-$(gnu_type).copyright: debian/copyright /usr/share/doc/gcc-$(gcc-version-major)-source/copyright /usr/share/doc/gdb-source/copyright
 	cp debian/copyright $@
-	echo -n "\n-----BEGIN GCC-$(gcc-version-major)-SOURCE COPYRIGHT INFORMATION-----\n" >> $@
+	echo >> $@
+	echo "-----BEGIN GCC-$(gcc-version-major)-SOURCE COPYRIGHT INFORMATION-----" >> $@
 	cat /usr/share/doc/gcc-$(gcc-version-major)-source/copyright >> $@
-	echo -n "-----END GCC-$(gcc-version-major)-SOURCE COPYRIGHT INFORMATION-----\n" \
-		"\n-----BEGIN GDB-SOURCE COPYRIGHT INFORMATION-----\n" >> $@
+	echo "-----END GCC-$(gcc-version-major)-SOURCE COPYRIGHT INFORMATION-----" >> $@
+	echo >> $@
+	echo "-----BEGIN GDB-SOURCE COPYRIGHT INFORMATION-----" >> $@
 	cat /usr/share/doc/gdb-source/copyright >> $@
-	echo -n "-----END GDB-SOURCE COPYRIGHT INFORMATION-----\n" >> $@
+	echo >> $@
+	echo "-----END GDB-SOURCE COPYRIGHT INFORMATION-----" >> $@
 debian/libnewlib-$(gnu_type)-dev.copyright: debian/copyright /usr/share/doc/newlib-source/copyright
 	cp debian/copyright $@
-	echo -n "\n-----BEGIN NEWLIB-SOURCE COPYRIGHT INFORMATION-----\n" >> $@
+	echo "-----BEGIN NEWLIB-SOURCE COPYRIGHT INFORMATION-----" >> $@
 	cat /usr/share/doc/newlib-source/copyright >> $@
-	echo -n "-----END NEWLIB-SOURCE COPYRIGHT INFORMATION-----\n" >> $@
+	echo "-----END NEWLIB-SOURCE COPYRIGHT INFORMATION-----" >> $@
 
 # The private shared library does not need ldconfig triggers.
 override_dh_makeshlibs:
-- 
2.30.2

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1003501-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1003501-close@bugs.debian.org

Subject: Bug#1003501: fixed in gcc-sh-elf 3

Date: Wed, 06 Apr 2022 13:19:29 +0000

Source: gcc-sh-elf
Source-Version: 3
Done: John Scott <jscott@posteo.net>

We believe that the bug you reported is fixed in the latest version of
gcc-sh-elf, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1003501@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
John Scott <jscott@posteo.net> (supplier of updated gcc-sh-elf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 02 Apr 2022 18:01:27 -0400
Source: gcc-sh-elf
Architecture: source
Version: 3
Distribution: experimental
Urgency: medium
Maintainer: Debian Electronics Team <pkg-electronics-devel@alioth-lists.debian.net>
Changed-By: John Scott <jscott@posteo.net>
Closes: 1003500 1003501
Changes:
 gcc-sh-elf (3) experimental; urgency=medium
 .
   * Switch to GCC 12.
   * Improve reproducibility by using tools in non-usrmerge locations
     with thanks to Vagrant Cascadian for the patch (Closes: #1003500)
   * Switch non-portable usage of echo to printf (Closes: #1003501)
     Thanks again to Vagrant.
Checksums-Sha1:
 af2afdcd00c85e109a0bb0e52493bf800d2ffd26 1754 gcc-sh-elf_3.dsc
 12854f4f9b395595811ff06c44db03aa27da8c5c 7980 gcc-sh-elf_3.tar.xz
 cc813e747bd5fbeec1c4ef0e2ab5a42e05a00855 6419 gcc-sh-elf_3_source.buildinfo
Checksums-Sha256:
 2090f7104d3f333ecee767ad6d82031669d279051a3e681e8de4c3cfcda88e94 1754 gcc-sh-elf_3.dsc
 6c9dd14110fd0e348f4aae99d4751527c5806364f9bedd84c50c6d7325c40d62 7980 gcc-sh-elf_3.tar.xz
 4f2ebe1a786439d7ce29e1533cca4ef0c0e27126a0b2f12b66a4f7fd7e7f49b7 6419 gcc-sh-elf_3_source.buildinfo
Files:
 36b9f600ba71661884f20acc8bbe5776 1754 devel optional gcc-sh-elf_3.dsc
 844d3bf809728e83c0950b81dd1d9097 7980 devel optional gcc-sh-elf_3.tar.xz
 089f61d575166e1e5cb20b5003e90b81 6419 devel optional gcc-sh-elf_3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmJNkQQQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFAs9DADSYW3jNug2Z0RQh3XH8U+rcCcA02r4aaxR
kfVwAAOQRogE7B7Dns+H70L4Csz/6qOg84kqhGrxEbxGJYp7JAbbx49JdQa5cCa7
88fEVmaS1oJ8D0+ZPx+xHKtJZMIynxL4gVOBMYkuZfp2RLtAhUNe0yxcCEF3gtkp
+q6m3YGq4xzvFKHZMuSCtMfYoPttf++YUC47GegV9ot4py/qJ3TOj7QaMYtnc5wc
YDL/bYoZOwLINdIFZag64vUZY4Jo7fq2Q0qMs9wh7BjxmtL3Wlzdvs+9b8mZ1AuB
GVZ8Yp6vYF5sy/pAb7wi3+/WK9BXKqIczPe9yT5nU+ygXUiAYlB7FrtSkZAXZV1b
0gjY8S9DrXd1Qga3lDNkJhVDlky7q5K3Vjb+P/R7+BP1hNkPsOkLil+N6nDx9653
01uogNXOnkSR1R1zfSDCvkAoYQvI1LE4LAx9U98u5qqVRO7fwWdgjGSRbxic+jMC
AUa/xPODaTa4dNQU4i6QWx7GL6nfn74=
=sm2j
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.