Debian Bug report logs - #1001869
libpodofo: reproducible-builds: BuildId differences triggered by RPATH

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: submit@bugs.debian.org

Subject: libpodofo: reproducible-builds: BuildId differences triggered by RPATH

Date: Fri, 17 Dec 2021 15:44:29 -0800

[Message part 1 (text/plain, inline)]

Source: libpodofo
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libpodofo.html

The attached patch to debian/rules passes
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
which should use a relative path for RPATH.

With this patch applied, libpodofo should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining libpodofo!

live well,
  vagrant

[0001-debian-rules-Pass-DCMAKE_BUILD_RPATH_USE_ORIGIN-ON-v.patch (text/x-diff, inline)]

From d0e8d3c6ba6214395035453eb799e30bba77a9c7 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 17 Dec 2021 23:42:10 +0000
Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure override.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index edb1e68..8b0a437 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,7 @@ override_dh_auto_configure:
 	    -DPODOFO_BUILD_SHARED:BOOL=TRUE \
 	    -DPODOFO_BUILD_STATIC:BOOL=FALSE \
 	    -DPODOFO_USE_VISIBILITY:BOOL=TRUE \
+	    -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON \
 
 override_dh_compress:
 	dh_compress -X .pdf -X .plan
-- 
2.34.1

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 1001869@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@mapreri.org>

To: Vagrant Cascadian <vagrant@reproducible-builds.org>, 1001869@bugs.debian.org

Subject: Re: Bug#1001869: libpodofo: reproducible-builds: BuildId differences triggered by RPATH

Date: Sat, 18 Dec 2021 00:51:06 +0100

[Message part 1 (text/plain, inline)]

Hi Vagrant,

Thank you for the patch, that I can surely apply, but I wonder if you had a
chance to have a look at the mass archive rebuild we had that applied this
flag to everything.

Just so to avoid spreading more boilerplate around...

On Sat, 18 Dec 2021, 12:48 am Vagrant Cascadian, <
vagrant@reproducible-builds.org> wrote:

> Source: libpodofo
> Severity: normal
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: buildpath
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
>
> The RPATH contains the build path resulting in different buildid:
>
>
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/libpodofo.html
>
> The attached patch to debian/rules passes
> -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
> which should use a relative path for RPATH.
>
> With this patch applied, libpodofo should build reproducibly on
> tests.reproducible-builds.org!
>
> Thanks for maintaining libpodofo!
>
> live well,
>   vagrant
>

[Message part 2 (text/html, inline)]

Message #15 received at 1001869@bugs.debian.org (full text, mbox, reply):

From: Vagrant Cascadian <vagrant@reproducible-builds.org>

To: Mattia Rizzolo <mattia@mapreri.org>, 1001869@bugs.debian.org

Subject: Re: Bug#1001869: libpodofo: reproducible-builds: BuildId differences triggered by RPATH

Date: Fri, 17 Dec 2021 17:38:20 -0800

[Message part 1 (text/plain, inline)]

On 2021-12-18, Mattia Rizzolo wrote:
> Thank you for the patch, that I can surely apply, but I wonder if you had a
> chance to have a look at the mass archive rebuild we had that applied this
> flag to everything.

That was a related but different flag, CMAKE_SKIP_RPATH=ON, and the
rebuild tests just tested weather they FTBFS, not the reproducibility
status.

  http://qa-logs.debian.net/2021/10/25/dcsr/
  http://qa-logs.debian.net/2021/10/25/res.dcsr.txt

That shows ~1k failures ... which is neither small nor huge.

In my limited experience, either can be used to make a package
reproducible, though I have a vague memory that possibly
CMAKE_BUILD_RPATH_USE_ORIGIN=ON might be less likely to cause FTBFS,
though I can't recall the details...


> Just so to avoid spreading more boilerplate around...

Yeah, I happen to have hit numerous packages today which become fully
reproducible with CMAKE_BUILD_RPATH_USE_ORIGIN=ON passed to
configure... just the luck of the packages I saw today!

To avoid boilerplate, switching to debhelper 14 would fix them (which
passes both CMAKE_SKIP_RPATH=ON and CMAKE_BUILD_RPATH_USE_ORIGIN=ON)
... but debhelper 14 is currently experiemental which involves a
different set of hoops to jump through to enable it.


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 1001869-submitter@bugs.debian.org (full text, mbox, reply):

From: Mattia Rizzolo <mattia@debian.org>

To: 1001869-submitter@bugs.debian.org

Subject: Bug#1001869 marked as pending in libpodofo

Date: Sun, 02 Jan 2022 18:03:56 +0000

Control: tag -1 pending

Hello,

Bug #1001869 in libpodofo reported by you has been fixed in the
Git repository and is awaiting an upload. You can see the commit
message below and you can check the diff of the fix at:

https://salsa.debian.org/debian/libpodofo/-/commit/16030bc80d8218ddbb0ebadf5ae056a94c5eca81

------------------------------------------------------------------------
Build with -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to make the build reproducible

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

Closes: #1001869
Signed-off-by: Mattia Rizzolo <mattia@debian.org>
------------------------------------------------------------------------

(this message was generated automatically)
-- 
Greetings

https://bugs.debian.org/1001869

Message #25 received at 1001869-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 1001869-close@bugs.debian.org

Subject: Bug#1001869: fixed in libpodofo 0.9.7+dfsg-3

Date: Sun, 02 Jan 2022 18:18:55 +0000

Source: libpodofo
Source-Version: 0.9.7+dfsg-3
Done: Mattia Rizzolo <mattia@debian.org>

We believe that the bug you reported is fixed in the latest version of
libpodofo, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1001869@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mattia Rizzolo <mattia@debian.org> (supplier of updated libpodofo package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 02 Jan 2022 18:57:57 +0100
Source: libpodofo
Architecture: source
Version: 0.9.7+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Mattia Rizzolo <mattia@debian.org>
Changed-By: Mattia Rizzolo <mattia@debian.org>
Closes: 1001869
Changes:
 libpodofo (0.9.7+dfsg-3) unstable; urgency=medium
 .
   [ Debian Janitor ]
   * Remove constraints unnecessary since buster:
     + Build-Depends: Drop versioned constraint on libfreetype6-dev.
 .
   [ Vagrant Cascadian ]
   * Build with -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to make the build
     reproducible.  Closes: #1001869
 .
   [ Mattia Rizzolo ]
   * Bump Standards-Version to 4.6.0, no changes needed.
   * Bump copyright year for debian/*.
Checksums-Sha1:
 31475fa54c364219442e8979af339f8912f911e8 2170 libpodofo_0.9.7+dfsg-3.dsc
 4af4eec253544ab0452371e7b143078b0a767f0c 8864 libpodofo_0.9.7+dfsg-3.debian.tar.xz
 0cf9d554cb16b9f8b40fabc602cfb046e0ea1a04 9061 libpodofo_0.9.7+dfsg-3_amd64.buildinfo
Checksums-Sha256:
 d9844dbcea6ed3e050e272dfc0fb7328481304e14833513437cee5caeb9c01ca 2170 libpodofo_0.9.7+dfsg-3.dsc
 7b20fe3769e1631cd6d0cb711c78c2f357ee25bc591f4fa6f59e0930c8cfbe13 8864 libpodofo_0.9.7+dfsg-3.debian.tar.xz
 afb72868fa58b460339cd5cf0e53e6a58872b0a0082849433c18b4ddef5e72d8 9061 libpodofo_0.9.7+dfsg-3_amd64.buildinfo
Files:
 33c5dbebfc2683ca7bb89806b19608b2 2170 libdevel optional libpodofo_0.9.7+dfsg-3.dsc
 75aec2ffa2aad7168ea6eec3c08c3370 8864 libdevel optional libpodofo_0.9.7+dfsg-3.debian.tar.xz
 f2e4f4b12c0ed91f1e8595efbf271834 9061 libdevel optional libpodofo_0.9.7+dfsg-3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAmHR6Q4ACgkQCBa54Yx2
K62ANBAAvXeszwUbq8Sp4zIJgBtBbur78qVcS4pztVf5pMLh/fILeYnZNpSqd4xg
qSZcy8byAIHKabZni81YCqMrb0W4OyxLYmu0DQvfGvEx3Wt4SO2zQfKjjF2PuffJ
SXtP9uVX6VEjOnU4Me13WorJKZMRsCmT2Vu/VHeQlrdaEBuifGmn+7QNtqssEtgo
ZxTnUBdvrHm3L0s/EFN/BRAaPOThNhKJu8PJMVRO9DxX6PYThI4MjAVpRzs5EqyG
giOEHehv1hAflgQnN1Z4nDwYRlnAV0ffNkVrBJTeY6S0i9CUID1XkzDivcwMniTw
ZiFU+XpXke8IdT64ytrXChT9Mri5T3E/4tEwD8RUPuC5UDdYi/ojXnB+RxQIeLAf
TWGMA1s1ybVXzL/+GQ710azSZn4qmlLN3fam5RoVjTas2hp6aNdoAZ6bKaE8fpjj
LuCTCtIwbSkD8slGEg301btj7Aqin4U4Rseoh4wTyy33ZytZl8pZBk18f1JyF+z4
2Kh4slPyv+HRLOHxxt/ruwbFD09gIaiWOKVMmziNMnX90mwOMizJTuHKGExkJV7E
cot+6zWR+Fcwi/MXgNSe0d+csdCWhUdBdBlbtcZzqa05Fwvc2Jka0R9pRfSz1O9C
udttOzjPqST+PdFFhSE9ycsYuWhO7tOxSKGH4WLz2cJSet5LyNM=
=TGq/
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.