Debian Bug report logs - #1000327
meson: please make the generated cmake files reproducible

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: submit@bugs.debian.org

Subject: meson: please make the generated cmake files reproducible

Date: Sun, 21 Nov 2021 09:41:35 -0800

[Message part 1 (text/plain, inline)]

Source: meson
Version: 0.60.1-1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps toolchain
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort we noticed that
meson is not generating reproducible .cmake files.

For example:

│ │ │ ├── ./usr/lib/x86_64-linux-gnu/cmake/xbyak/xbyakConfig.cmake
│ │ │ │ @@ -1,11 +1,11 @@
│ │ │ │  
│ │ │ │  ####### Expanded from @PACKAGE_INIT@ by configure_package_config_file() #######
│ │ │ │  ####### Any changes to this file will be overwritten by the next CMake run ####
│ │ │ │ -####### The input file was /build/1st/xbyak-6.00/cmake/meson-config.cmake.in ########
│ │ │ │ +####### The input file was /build/2/xbyak-6.00/2nd/cmake/meson-config.cmake.in ########

(This is from src:xbyak version 6.00-2.)

A patch is attached that uses os.path.basename to only include
"meson-config.cmake.in" instead of the full path. This not only makes
the build reproducible, but it also matches CMake's own behaviour.
Specifically, CMakePackageConfigHelpers.cmake does the equivalent
transformation using:

  get_filename_component(inputFileName "${_inputFile}" NAME)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[meson.diff.txt (text/plain, attachment)]

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Jussi Pakkanen <jpakkane@gmail.com>

To: Chris Lamb <lamby@debian.org>, 1000327@bugs.debian.org

Cc: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#1000327: meson: please make the generated cmake files reproducible

Date: Sun, 21 Nov 2021 19:52:54 +0200

On Sun, 21 Nov 2021 at 19:45, Chris Lamb <lamby@debian.org> wrote:

> Whilst working on the Reproducible Builds effort we noticed that
> meson is not generating reproducible .cmake files.
>
> A patch is attached that uses os.path.basename to only include
> "meson-config.cmake.in" instead of the full path. This not only makes
> the build reproducible, but it also matches CMake's own behaviour.
> Specifically, CMakePackageConfigHelpers.cmake does the equivalent
> transformation using:

Please file this (and all future patches of this type) directly to the
upstream project. All functional changes must be done via upstream
releases (the few patches we have deal with weird test setups and the
like).

Message #22 received at 1000327@bugs.debian.org (full text, mbox, reply):

From: "Chris Lamb" <lamby@debian.org>

To: "Jussi Pakkanen" <jpakkane@gmail.com>, 1000327@bugs.debian.org

Subject: Re: Bug#1000327: meson: please make the generated cmake files reproducible

Date: Sun, 21 Nov 2021 09:53:59 -0800

forwarded 1000327 https://github.com/mesonbuild/meson/pull/9602
thanks

> Please file this (and all future patches of this type) directly to the
> upstream project. All functional changes must be done via upstream
> releases (the few patches we have deal with weird test setups and the
> like).

Sure thing. I've forwarded this upstream here:

  https://github.com/mesonbuild/meson/pull/9602


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

Message #29 received at 1000327@bugs.debian.org (full text, mbox, reply):

From: gocomsearch@gmail.com

To: 1000327@bugs.debian.org

Subject: New Internet Search Engine

Date: Sun, 5 Dec 2021 16:32:14 -0800

[Message part 1 (text/html, inline)]

Message #34 received at 1000327-done@bugs.debian.org (full text, mbox, reply):

From: Simon McVittie <smcv@debian.org>

To: 1000327-done@bugs.debian.org

Subject: Re: Bug#1000327: meson: please make the generated cmake files reproducible

Date: Tue, 16 Aug 2022 10:59:48 +0100

Version: 0.61.0~rc1-1

On Sun, 21 Nov 2021 at 09:53:59 -0800, Chris Lamb wrote:
> > Please file this (and all future patches of this type) directly to the
> > upstream project
> 
> Sure thing. I've forwarded this upstream here:
> 
>   https://github.com/mesonbuild/meson/pull/9602

This change appears to have been included in 0.61.0rc1.

    smcv

Send a report that this bug log contains spam.