Debian Bug report logs - #100028
pppd with "persist" and "holdoff 0" options does not exit on a SIGTERM received prior to connection

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Daniel Ginsburg <dg@warpsolutions.com>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: pppd fails to terminate while executing connect script

Date: Fri, 8 Jun 2001 05:20:15 +0400

Package: ppp
Version: 2.4.1-1
Severity: normal
Tags: patch sid

If options 'persist' and 'holdoff 0' are set ppp fails to terminate on
SIGTERM. It only kills connect script, restarts it immediately and
continue running. When connection established pppd terminates ok on
SIGTERM/SIGINT.

The nature of problem is pppd's SIGTERM/SIGINT handler sets flag but
fails to check it in main loop when no connection established yet and
holdoff period is 0. The fix is one line.

Corrected debian/patches/017_main.c.diff:
--- ppp-2.4.1.orig/pppd/main.c	Tue Mar 13 08:56:19 2001
+++ ppp-2.4.1/pppd/main.c	Fri Jun  8 00:25:46 2001
@@ -548,6 +548,7 @@
 	    pidfilename[0] = 0;
 	}
 
+	handle_events();
 	if (!persist || (maxfail > 0 && unsuccess >= maxfail))
 	    break;
 
@@ -1778,7 +1779,8 @@
     dbuf.dsize = vlen;
     if (tdb_store(pppdb, key, dbuf, TDB_REPLACE))
 	error("tdb_store failed: %s", tdb_error(pppdb));
-
+    free(vbuf);
+    
 }
 
 /*

-- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux rain 2.4.1 #1 Пнд Мар 19 21:34:46 MSK 2001 i586
Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R

Versions of packages ppp depends on:
ii  libc6                         2.2.3-5    GNU C Library: Shared libraries an
ii  libpam-modules                0.72-24    Pluggable Authentication Modules f
ii  libpam0g                      0.72-24    Pluggable Authentication Modules l
ii  netbase                       4.05       Basic TCP/IP networking system    
ii  sysvinit                      2.78-4     System-V like init.               

-- 
dg

Message #10 received at 100028-close@bugs.debian.org (full text, mbox, reply):

From: Michael Beattie <mjb@debian.org>

To: 100028-close@bugs.debian.org

Subject: Bug#100028: fixed in ppp 2.4.1-2

Date: Sat, 16 Jun 2001 14:58:20 -0400

We believe that the bug you reported is fixed in the latest version of
ppp, which has been installed in the Debian FTP archive:

ppp_2.4.1-2_i386.deb
  to pool/main/p/ppp/ppp_2.4.1-2_i386.deb
ppp-udeb_2.4.1-2_i386.udeb
  to pool/main/p/ppp/ppp-udeb_2.4.1-2_i386.udeb
ppp_2.4.1-2.dsc
  to pool/main/p/ppp/ppp_2.4.1-2.dsc
ppp_2.4.1-2.diff.gz
  to pool/main/p/ppp/ppp_2.4.1-2.diff.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 100028@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Beattie <mjb@debian.org> (supplier of updated ppp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 16 Jun 2001 06:24:35 +1200
Source: ppp
Binary: ppp ppp-udeb
Architecture: source i386
Version: 2.4.1-2
Distribution: unstable
Urgency: low
Maintainer: Michael Beattie <mjb@debian.org>
Changed-By: Michael Beattie <mjb@debian.org>
Description: 
 ppp        - Point-to-Point Protocol (PPP) daemon.
 ppp-udeb   - Point-to-Point Protocol (PPP) daemon. (udeb)
Closes: 88844 94682 100028
Changes: 
 ppp (2.4.1-2) unstable; urgency=low
 .
   * Using fixed debhelper, update-modules now only gets called if it is
     actally available. (Closes: #94682)
   * Removed start-stop-daemon call in prerm, dh_installinit does this now.
   * removed suidunregister calls in postrm (oops)
   * Added pppoe patch, we can now use kernel mode pppoe :> - Paul says he's
     working on a better patch for 2.4.2, but I want pppoe for my own
     purposes... go figure. (Closes: #88844)
   * Added patch from Daniel Ginsburg for signal handling bug.
     (Closes: #100028)
Files: 
 a4758c1eaa89d80ca15830661d9b6da0 608 net standard ppp_2.4.1-2.dsc
 f454a844c22591cfca3672f3be943762 65687 net standard ppp_2.4.1-2.diff.gz
 6a11c8308e5a79aa04eecf29721f3631 252910 net standard ppp_2.4.1-2_i386.deb
 d81eecf9657db7aefc33f81951cb0e86 90418 debian-installer standard ppp-udeb_2.4.1-2_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Michael Beattie <mjb@debian.org>

iEYEARECAAYFAjsrfugACgkQBSsR1azesLO1mgCeJROdxHFUbE9vBhoA9mnsFaz7
zXEAnA8plbhbGuAW7NjFSr4sH30Gjf2H
=DHUo
-----END PGP SIGNATURE-----

Message #29 received at 100028-quiet@bugs.debian.org (full text, mbox, reply):

From: Thomas Hood <jdthood@aglu.demon.nl>

To: 100028-quiet@bugs.debian.org

Subject: patch no good

Date: Tue, 16 Nov 2004 10:00:08 +0100

tags 100028 - patch
tags 100028 - sid
thanks

The current pppd does not have the patch applied, so I guess the bug
remains.  However, Michael Beattie says that the patch supplied by
Daniel Ginsburg causes major breakage, so a new solution is needed.

Send a report that this bug log contains spam.