Debian Bug report logs - #248070
hotplug: usb.agent does not set REMOVER correctly on remove on 2.6 kernels

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Bart Samwel <bart@samwel.tk>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: hotplug: usb.agent does not set REMOVER correctly on remove on 2.6 kernels

Date: Sun, 09 May 2004 03:00:12 +0200

Package: hotplug
Version: 0.0.20040329-8
Severity: important

Hi there,

I've been trying to do my own USB storage automounting on my unstable
box running Linux 2.6.6-rc3-mm2. The mounting works perfectly, but when
I tried to do an "umount -f /pen" in a REMOVER script I found out that
it doesn't work. The reason it doesn't work is quite simple: for 2.6
kernels, the name of the remover script is calculated from the sysfs
device path, which doesn't exist anymore when the device is already
removed. :) The relevant line from /etc/hotplug/usb.agent:

REMOVER=/var/run/usb/$(readlink -f $SYSFS/$DEVPATH | sed -e 's;/;%;g')

I've added debugging echo statements, and it turns out that on $ACTION =
add, this sets REMOVER to
"/var/run/usb/%sys%devices%pci0000:00%0000:00:07.2%usb1%1-1%1-1:1.0",
while on $ACTION = remove, REMOVER is set to "/var/run/usb/".

My temporary fix: to remove the if clause containing this calculation of
remover completely. The if in the script says something about being for
2.6:

if [ "$DEVPATH" != "" ]; then
  # probably, 2.6.x

and the subsequent clause says that it's for 2.4:

if [ "$DEVICE" != "" ]; then
  # 2.4.x?
    REMOVER=/var/run/usb/$(echo $DEVICE | sed -e 's;/;%;g')

but the "2.6" version can _never_ work when a device is already removed.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.6-rc3-mm2
Locale: LANG=C, LC_CTYPE=C

Versions of packages hotplug depends on:
ii  debconf                      1.4.25      Debian configuration management sy
ii  module-init-tools            3.0-pre10-2 tools for managing Linux kernel mo
ii  modutils                     2.4.26-1    Linux module utilities
ii  procps                       1:3.2.1-2   The /proc file system utilities

-- debconf information:
  hotplug/ignore_pci_class_display: true
  hotplug/net_agent_policy: hotplug
  hotplug/static_module_list: 
  hotplug/usbd_enable: true
* hotplug/usb_keyboard: 
  hotplug/x11_usbmice_hack: false

Message #10 received at 248070-close@bugs.debian.org (full text, mbox, reply):

From: Marco d'Itri <md@linux.it>

To: 248070-close@bugs.debian.org

Subject: Bug#248070: fixed in hotplug 0.0.20040329-12

Date: Sun, 18 Jul 2004 10:17:03 -0400

Source: hotplug
Source-Version: 0.0.20040329-12

We believe that the bug you reported is fixed in the latest version of
hotplug, which is due to be installed in the Debian FTP archive:

hotplug_0.0.20040329-12.diff.gz
  to pool/main/h/hotplug/hotplug_0.0.20040329-12.diff.gz
hotplug_0.0.20040329-12.dsc
  to pool/main/h/hotplug/hotplug_0.0.20040329-12.dsc
hotplug_0.0.20040329-12_all.deb
  to pool/main/h/hotplug/hotplug_0.0.20040329-12_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 248070@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Marco d'Itri <md@linux.it> (supplier of updated hotplug package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 18 Jul 2004 01:20:44 +0200
Source: hotplug
Binary: hotplug
Architecture: source all
Version: 0.0.20040329-12
Distribution: unstable
Urgency: low
Maintainer: Fumitoshi UKAI <ukai@debian.or.jp>
Changed-By: Marco d'Itri <md@linux.it>
Description: 
 hotplug    - Linux Hotplug Scripts
Closes: 237952 243716 243716 243716 245500 248070 248304 248900 252287 253927 256893 256897 257043 257723 257849 257867 259141 259488
Changes: 
 hotplug (0.0.20040329-12) unstable; urgency=low
 .
   * Install the isapnp modprobe aliases in the right place.
   * New patch 012_usb.rc_fix_coldplugging to generate more correct
     coldplugging events for USB. Requires kernel >= 2.6.7.
     Remove obsolete patches 012_usb.rc_no_usbmodules and
     012_usb.rc_try_all_interfaces.
     (Closes: #243716, #245500, #243716, #243716, #248900, #237952, #248304)
     (Closes: #252287, #253927)
   * Removed patch 009_usb.agent_remover, it's broken (the $DEVPATH does
     not exist anymore on removal) and useless because now $DEVICE should
     always be generated. (Closes: #248070)
   * Create the net.enable flag file in postinst. (Closes: #256897)
   * Updated patch 050_net.agent_ifupdown to make net.ifup print a debug
     message only if net.enable does not exist yet. (Closes: #256893)
   * Updated patch firmware_dirs to search for firmware files in
     /usr/local/lib/firmware/ too. (Closes: #257849)
   * New patch 017_pci.rc_pcimodules_once to run pcimodules only once on
     2.4 systems. (Closes: #259488)
   * Updated po templates: da, fr. (Closes: #257867, #259141)
   * Updated isapnp.rc to support blacklisting by module name.
     Patch courtesy of Santi Béjar. (Closes: #257043)
   * Depend on grep >= 2.5.1.ds1-2, which fixes -q. (Closes: #257723)
Files: 
 fbc3277dd3eb1849a8df8dabaec15f9f 673 admin standard hotplug_0.0.20040329-12.dsc
 45b332380fa4aa817d099864e73482b5 40361 admin standard hotplug_0.0.20040329-12.diff.gz
 c6f06f279fead4f1524187d233f88309 60824 admin standard hotplug_0.0.20040329-12_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA+oKrFGfw2OHuP7ERAgcvAJ9SpxeW28+j//HCV8V7Hbhr+4/RwgCgpct6
WYsdt6twGihzROhtA0fPQfU=
=UK7A
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.