Debian Bug report logs - #511152
dpkg-dev: dpkg-buildpackage -v0 does not work

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: "Nikita V. Youshchenko" <yoush@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: dpkg-dev: dpkg-buildpackage -v0 does not work
Date: Wed, 07 Jan 2009 23:27:07 +0300

Package: dpkg-dev
Version: 1.14.23
Severity: normal

I've just found that if I pass '-v0' to dpkg-buildpackage (meaning 'include
changelog since version 0'), then -v0 parameter is not passed to
dpkg-genchanges.

This is caused by the line

if ($since) { push @change_opts, "-v$since" }

because if $since is 0, condition is false. Better to write

if (defined($since)) { push @change_opts, "-v$since" }

dpkg-genchanges also has exactly the same issue processing '-v0'.

-- System Information:
Debian Release: 5.0
  APT prefers testing
  APT policy: (620, 'testing'), (600, 'unstable'), (550, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R (charmap=KOI8-R)
Shell: /bin/sh linked to /bin/bash

Versions of packages dpkg-dev depends on:
ii  binutils            2.18.1~cvs20080103-7 The GNU assembler, linker and bina
ii  bzip2               1.0.5-1              high-quality block-sorting file co
ii  cpio                2.9-13               GNU cpio -- a program to manage ar
ii  dpkg                1.14.23              Debian package management system
ii  libtimedate-perl    1.1600-9             Time and date functions for Perl
ii  lzma                4.43-14              Compression method of 7z format in
ii  make                3.81-5               The GNU version of the "make" util
ii  patch               2.5.9-5              Apply a diff file to an original
ii  perl [perl5]        5.10.0-18            Larry Wall's Practical Extraction 
ii  perl-modules        5.10.0-18            Core Perl modules

Versions of packages dpkg-dev recommends:
ii  build-essential               11.4       Informational list of build-essent
ii  gcc [c-compiler]              4:4.3.2-2  The GNU C compiler
ii  gcc-4.1 [c-compiler]          4.1.2-23   The GNU C compiler
ii  gcc-4.3 [c-compiler]          4.3.2-1    The GNU C compiler

Versions of packages dpkg-dev suggests:
pn  debian-keyring                <none>     (no description available)
ii  gnupg                         1.4.9-3    GNU privacy guard - a free PGP rep

-- no debconf information

Message #10 received at 511152@bugs.debian.org (full text, mbox):

From: Guillem Jover <guillem@debian.org>
To: "Nikita V. Youshchenko" <yoush@debian.org>, 511152@bugs.debian.org
Subject: Re: Bug#511152: dpkg-dev: dpkg-buildpackage -v0 does not work
Date: Wed, 7 Jan 2009 23:32:07 +0200

user dpkg@packages.debian.org
usertag 511152 dpkg-buildpackage
merge 475916 511152
thanks

Hi!

On Wed, 2009-01-07 at 23:27:07 +0300, Nikita V. Youshchenko wrote:
> Package: dpkg-dev
> Version: 1.14.23
> Severity: normal
> 
> I've just found that if I pass '-v0' to dpkg-buildpackage (meaning 'include
> changelog since version 0'), then -v0 parameter is not passed to
> dpkg-genchanges.
> 
> This is caused by the line
> 
> if ($since) { push @change_opts, "-v$since" }
> 
> because if $since is 0, condition is false. Better to write
> 
> if (defined($since)) { push @change_opts, "-v$since" }
> 
> dpkg-genchanges also has exactly the same issue processing '-v0'.

This was already reported. Raphaël also commented there on some of the
additionaly needed changes.

regards,
guillem

Send a report that this bug log contains spam.