Debian Bug report logs - #459885
markdown: does not handle well [foo bar][]-links with a newline inside

Reply or subscribe to this bug.

Toggle useless messages

Message #5 received at submit@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: markdown: does not handle well [foo bar][]-links with a newline
	inside
Date: Wed, 9 Jan 2008 11:44:47 +0100

Package: markdown
Version: 1.0.1-7
Severity: normal
Tags: upstream

Hello.

It seems that Markdown does not handle well a [foo bar][] link when a
newline happens to make its way into separating the two words inside the
square brackets. For an input file like:

-8<-
Bla, bla, bla, bla, bla, bla, bla, bla, bla, bla bla. This is [my
University][].

  [my university]: http://www.ua.es
->8-

The version in unstable, 1.0.1, will omit the link and leave the
brackets in place.

Things get a bit better with the version in unstable, 1.0.2~b8, with
which the output is:

-8<-
<p>Bla, bla, bla, bla, bla, bla, bla, bla, bla, bla bla. This is <a href="http://www.ua.es">my
University</a>[].</p>
->8-

Almost what's desired, except that the second pair of brackets is left
in the output.

It'd be very nice if this could get fixed for 1.0.2.

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
Never let your sense of morals get in the way of doing what's right.
                -- Isaac Asimov

Message #10 received at 459885@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: 459885@bugs.debian.org
Subject: Re: Bug#459885: markdown: does not handle well [foo bar][]-links
	with a newline inside
Date: Wed, 9 Jan 2008 13:59:25 +0100

* Adeodato Simó [Wed, 09 Jan 2008 11:44:47 +0100]:

> Things get a bit better with the version in unstable, 1.0.2~b8, with
> which the output is:

> -8<-
> <p>Bla, bla, bla, bla, bla, bla, bla, bla, bla, bla bla. This is <a href="http://www.ua.es">my
> University</a>[].</p>
> ->8-

> Almost what's desired, except that the second pair of brackets is left
> in the output.

Ah, but I see now that this is a "new feature", by which a sole [foo
bar] without a second pair of brackets becomes a link iff it's defined
somewhere.

While this is *very* nice, there's a still (IMHO) a bug in the handling
of newlines inside the brackets. This works the same in 1.0.1 and 1.0.2:

-8<-
[my university][]
->8-

But this does not work in either:

-8<-
[my
university][]
->8-

In 1.0.1 it doesn't work at all, and in 1.0.2 it gets interpreted as one
of the new [without second pair of brackets] style links, and the second
pair gets printed verbatim in the output.

I may poke at the code later.

Cheers,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
— As the ship lay in Boston Harbor, a party the colonists dressed as red
  Indians boarded the vessel, behaved very rudely, and threw all the tea
  overboard, making the tea unsuitable for drinking. Even for Americans. 
                -- George W. Banks in “Mary Poppins”

Message #15 received at 459885@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: 459885@bugs.debian.org
Cc: control@bugs.debian.org
Subject: Re: Bug#459885: markdown: does not handle well [foo bar][]-links
	with a newline inside
Date: Wed, 9 Jan 2008 17:19:59 +0100

[Message part 1 (text/plain, inline)]

tag 459885 patch
thanks

* Adeodato Simó [Wed, 09 Jan 2008 13:59:25 +0100]:

> But this does not work in either:

> -8<-
> [my
> university][]
> ->8-

> In 1.0.1 it doesn't work at all, and in 1.0.2 it gets interpreted as one
> of the new [without second pair of brackets] style links, and the second
> pair gets printed verbatim in the output.

> I may poke at the code later.

Okay, simple enough. It seems to me that the same substitution of \n
into spaces that is performed for the [link without second pair of
brackets] case should be made for the [other type][] of link.

I attach a patch. Note that the line that I add is copied verbatim from
some lines below in the code. It would be very nice to have this applied
to the package, even if forwarding upstream yields no answer.

Thanks!

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
As scarce as truth is, the supply has always been in excess of the demand.
                -- Josh Billings

[markdown.diff (text/x-diff, attachment)]

Message #22 received at 459885@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: 459885@bugs.debian.org
Subject: Re: Bug#459885: markdown: does not handle well [foo bar][]-links
	with a newline inside
Date: Wed, 9 Jan 2008 17:33:10 +0100

* Adeodato Simó [Wed, 09 Jan 2008 17:19:59 +0100]:

> I attach a patch. Note that the line that I add is copied verbatim from
> some lines below in the code. It would be very nice to have this applied
> to the package, even if forwarding upstream yields no answer.

Oops, sorry, patch was wrong. Attached a good one this time, and a
clarification: the patch drags code/the idea from markdown 1.0.2~b8, but
it applies both to 1.0.1 in unstable and 1.0.2 in experimental. If you
could apply it to both branches, that'd be very nice.

Cheers,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
                Listening to: Manolo García - Nunca el tiempo es perdido

Message #27 received at 459885@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: 459885@bugs.debian.org
Subject: Re: Bug#459885: markdown: does not handle well [foo bar][]-links
	with a newline inside
Date: Wed, 9 Jan 2008 17:34:40 +0100

[Message part 1 (text/plain, inline)]

> Oops, sorry, patch was wrong. Attached a good one this time,

God, what a ghostly mess. Attached now.

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
              Listening to: Manolo García - Mientras observo al afilador

[markdown.diff (text/x-diff, attachment)]

Message #32 received at 459885@bugs.debian.org (full text, mbox):

From: Tomas Doran <bobtfish@bobtfish.net>
To: 459885@bugs.debian.org
Date: Fri, 21 Mar 2008 22:22:13 +0000

I've applied one of the patches.

svn diff -r 446:447 http://svn.kulp.ch/cpan/text_multimarkdown/trunk

Doing the change for supporting multiple new lines is a slightly  
harder case, which I'm not going to look into now - however I have  
added a failing test case to cover it.

This will be present in the 1.0.18 release (current version is http:// 
search.cpan.org/CPAN/authors/id/B/BO/BOBTFISH/Text- 
Markdown-1.0.17.tar.gz).

Cheers
Tom

Message #37 received at 459885@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: 459885@bugs.debian.org
Subject: Re: Bug#459885:
Date: Tue, 25 Mar 2008 19:32:31 +0100

* Tomas Doran [Fri, 21 Mar 2008 22:22:13 +0000]:

> I've applied one of the patches.
> svn diff -r 446:447 http://svn.kulp.ch/cpan/text_multimarkdown/trunk

For those reading along, this is not the upstream of "Package: markdown"
as found in Debian, but of the Text::Markdown module as found on CPAN.

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
We may not return the affection of those who like us, but we always
respect their good judgement.

Message #42 received at 459885@bugs.debian.org (full text, mbox):

From: Adeodato Simó <dato@net.com.org.es>
To: 459885@bugs.debian.org
Subject: Re: Bug#459885:
Date: Thu, 6 Nov 2008 12:55:26 +0100

* Adeodato Simó [Tue, 25 Mar 2008 19:32:31 +0100]:

> * Tomas Doran [Fri, 21 Mar 2008 22:22:13 +0000]:

> > I've applied one of the patches.
> > svn diff -r 446:447 http://svn.kulp.ch/cpan/text_multimarkdown/trunk

> For those reading along, this is not the upstream of "Package: markdown"
> as found in Debian, but of the Text::Markdown module as found on CPAN.

(Found in Debian in the libtext-markdown-perl package.)

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
- Oh my God, you're pimping me out for a new roof?
- And windows!
                -- Andrew and Bree Van De Kamp

Send a report that this bug log contains spam.